Skip to content

fix: RBR is not close to chevron #86646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daledah wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix: RBR is not close to chevron #86646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e3f4bb
fix: RBR is not close to chevron
daledah Mar 30, 2026
4c21d1f
fix toggle margin
daledah Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ function MenuItem({
</View>
)}
{!!brickRoadIndicator && (
<View style={[styles.alignItemsCenter, styles.justifyContentCenter, styles.ml1]}>
<View style={[styles.alignItemsCenter, styles.justifyContentCenter, styles.ml1, styles.mr2]}>
<Icon
src={icons.DotIndicator}
fill={brickRoadIndicator === CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR ? theme.danger : theme.success}
Expand All @@ -1096,7 +1096,7 @@ function MenuItem({
<View
style={[
styles.pointerEventsAuto,
StyleUtils.getMenuItemIconStyle(isCompact),
StyleUtils.getMenuItemIconStyle(true),
disabled && !shouldUseDefaultCursorWhenDisabled && styles.cursorDisabled,
hasSubMenuItems && styles.pl6,
!isHovered && shouldDimIconRight && styles.opacitySemiTransparent,
Expand Down
2 changes: 1 addition & 1 deletion src/components/ReportActionItem/MoneyRequestView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ function MoneyRequestView({
{shouldShowReimbursable && (
<OfflineWithFeedback
pendingAction={getPendingFieldAction('reimbursable')}
contentContainerStyle={[styles.flexRow, styles.optionRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.ml5, styles.mr8]}
contentContainerStyle={[styles.flexRow, styles.optionRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.m5]}
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep reimbursable row margin horizontal-only

Replacing styles.ml5, styles.mr8 with styles.m5 applies margin: 20 on all sides, not just left/right. When the reimbursable toggle is shown, this adds unintended 20px top and bottom spacing around the row, creating a visible layout regression compared with neighboring rows (e.g., billable) that still use horizontal-only spacing.

Useful? React with 👍 / 👎.

>
<View>
<Text
Expand Down
Loading