Conversation
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dominictb we have the follow up PR here |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c21d1f1c5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <OfflineWithFeedback | ||
| pendingAction={getPendingFieldAction('reimbursable')} | ||
| contentContainerStyle={[styles.flexRow, styles.optionRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.ml5, styles.mr8]} | ||
| contentContainerStyle={[styles.flexRow, styles.optionRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.m5]} |
There was a problem hiding this comment.
Keep reimbursable row margin horizontal-only
Replacing styles.ml5, styles.mr8 with styles.m5 applies margin: 20 on all sides, not just left/right. When the reimbursable toggle is shown, this adds unintended 20px top and bottom spacing around the row, creating a visible layout regression compared with neighboring rows (e.g., billable) that still use horizontal-only spacing.
Useful? React with 👍 / 👎.
trjExpensify
left a comment
There was a problem hiding this comment.
@Expensify/design one for ya'll.
|
We've commented on the top issues on this one already so let's follow that 👍 |
1 similar comment
|
We've commented on the top issues on this one already so let's follow that 👍 |
Explanation of Change
Fixed Issues
$ #86561
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari