Skip to content

fix(mini-frames): persist scale/position on login and slider change #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EllesmereGaming merged 1 commit into from
Mar 11, 2026
+5 −11
Merged

fix(mini-frames): persist scale/position on login and slider change #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions EllesmereUIUnitFrames/EUI_UnitFrames_Options.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6534,17 +6534,7 @@ initFrame:SetScript("OnEvent", function(self)
getValue=function() return settingsTable.frameScale or 100 end,
setValue=function(v)
settingsTable.frameScale = v
if ns.ApplyFrameScale then
for unit, frame in pairs(ns.frames or {}) do
if type(unit) == "string" and unit:sub(1,1) ~= "_" then
local uKey = unit:match("^boss%d$") and "boss" or (unit == "targettarget" or unit == "focustarget") and "totPet" or unit
if db.profile[uKey] == settingsTable then
ns.ApplyFrameScale(frame, unit)
end
end
end
end
UpdatePreview()
ReloadAndUpdate()
end }, { type="label", text="" }); y = y - h

-- TEXT section
Expand Down
4 changes: 4 additions & 0 deletions EllesmereUIUnitFrames/EllesmereUIUnitFrames.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5959,6 +5959,7 @@ function InitializeFrames()
oUF:SetActiveStyle("EllesmerePet")
frames.pet = oUF:Spawn("pet", "EllesmereUIUnitFrames_Pet")
ApplyFramePosition(frames.pet, "pet")
ApplyFrameScale(frames.pet, "pet")
SetupUnitMenu(frames.pet, "pet")
if enabled.pet == false then
frames.pet:Hide()
Expand All @@ -5968,6 +5969,7 @@ function InitializeFrames()
oUF:SetActiveStyle("EllesmereTargetTarget")
frames.targettarget = oUF:Spawn("targettarget", "EllesmereUIUnitFrames_TargetTarget")
ApplyFramePosition(frames.targettarget, "targettarget")
ApplyFrameScale(frames.targettarget, "targettarget")
SetupUnitMenu(frames.targettarget, "targettarget")
if enabled.targettarget == false then
frames.targettarget:Hide()
Expand All @@ -5977,6 +5979,7 @@ function InitializeFrames()
oUF:SetActiveStyle("EllesmereFocusTarget")
frames.focustarget = oUF:Spawn("focustarget", "EllesmereUIUnitFrames_FocusTarget")
ApplyFramePosition(frames.focustarget, "focustarget")
ApplyFrameScale(frames.focustarget, "focustarget")
SetupUnitMenu(frames.focustarget, "focustarget")
if enabled.focustarget == false then
frames.focustarget:Hide()
Expand Down Expand Up @@ -6339,6 +6342,7 @@ function SetupOptionsPanel()
if scale then
local unitKey = (k == "boss") and "boss"
or (k == "classPower") and nil
or (k == "targettarget" or k == "focustarget") and "totPet"
or k
if unitKey and db.profile[unitKey] then
db.profile[unitKey].frameScale = math.floor(scale * 100 + 0.5)
Expand Down