Skip to content

fix(mini-frames): persist scale/position on login and slider change#49

Merged
EllesmereGaming merged 1 commit intoEllesmereGaming:mainfrom
natty:fix/mini-frames-gone-wild
Mar 11, 2026
Merged

fix(mini-frames): persist scale/position on login and slider change#49
EllesmereGaming merged 1 commit intoEllesmereGaming:mainfrom
natty:fix/mini-frames-gone-wild

Conversation

@natty
Copy link
Contributor

@natty natty commented Mar 11, 2026

Bug

Target of Target, Focus Target, and Pet Frame resets size and position after logging in/out and /reload. It sometimes goes extra wild on slider change in unlock mode and appears with a random location on screen.

Root Cause

Missing ApplyFrameScale call in InitializeFrames for pet/targettarget/focustarget. Everything else cascades from that — the wrong position on reload, the options panel needing ReloadAndUpdate, the savePosition key mapping bug being exposed. The core omission is that three frames were simply never having their saved scale applied on login.

Fix

ApplyFrameScale never called in InitializeFrames for pet/targettarget/focustarget — scale always loaded as 1.0 on login savePosition wrote frameScale to db.profile["targettarget"] which doesn't exist — targettarget and focustarget both share db.profile.totPet, so the scale was silently dropped on every unlock mode save
Options panel scale slider used ns.ApplyFrameScale (no position compensation) instead of ReloadAndUpdate

Test

Open unlock mode, set pet scale to something non-default (e.g. 150%)
/reload — pet should stay at 150%, same position
Repeat for ToT and focustarget
Change ToT scale — confirm focustarget also changes (they share totPet)

/eui → Unit Frames → Mini Frames Edit → set pet scale to non-default
Frames should update visually immediately (live preview)
/reload — pet should stay at that scale, correct position (not bottom-right corner)
/reload again — still correct
Repeat for ToT/focustarget slider

Regression check
Set scale back to 100% via both paths — confirm frames return to default position cleanly
Confirm player/target/focus frames are unaffected throughout
Set position via unlock mode drag, then change scale — confirm position compensates correctly and survives /reload

@EllesmereGaming EllesmereGaming merged commit e323804 into EllesmereGaming:main Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants