Skip to content

Add SetBaseURL setter methods for proper encapsulation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SantiagoDePolonia merged 3 commits into from
Dec 7, 2025
Merged

Add SetBaseURL setter methods for proper encapsulation #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2412f05
Initial plan
Copilot Dec 7, 2025
ec56df0
Initial plan for addressing baseURL encapsulation feedback
Copilot Dec 7, 2025
216bb24
feat: add SetBaseURL method for better encapsulation
Copilot Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions config/config.yaml
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion internal/providers/anthropic/anthropic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func init() {
p := New(cfg.APIKey)
// Override base URL if provided in config
if cfg.BaseURL != "" {
p.baseURL = cfg.BaseURL
p.SetBaseURL(cfg.BaseURL)
}
return p, nil
})
Expand Down Expand Up @@ -60,6 +60,11 @@ func NewWithHTTPClient(apiKey string, client *http.Client) *Provider {
}
}

// SetBaseURL allows configuring a custom base URL for the provider
func (p *Provider) SetBaseURL(url string) {
p.baseURL = url
}

// Supports returns true if this provider can handle the given model
func (p *Provider) Supports(model string) bool {
return strings.HasPrefix(model, "claude-")
Expand Down
7 changes: 6 additions & 1 deletion internal/providers/gemini/gemini.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func init() {
p := New(cfg.APIKey)
// Override base URL if provided in config
if cfg.BaseURL != "" {
p.baseURL = cfg.BaseURL
p.SetBaseURL(cfg.BaseURL)
}
return p, nil
})
Expand Down Expand Up @@ -63,6 +63,11 @@ func NewWithHTTPClient(apiKey string, client *http.Client) *Provider {
}
}

// SetBaseURL allows configuring a custom base URL for the provider
func (p *Provider) SetBaseURL(url string) {
p.baseURL = url
}

// Supports returns true if this provider can handle the given model
func (p *Provider) Supports(model string) bool {
return strings.HasPrefix(model, "gemini-")
Expand Down
7 changes: 6 additions & 1 deletion internal/providers/openai/openai.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func init() {
p := New(cfg.APIKey)
// Override base URL if provided in config
if cfg.BaseURL != "" {
p.baseURL = cfg.BaseURL
p.SetBaseURL(cfg.BaseURL)
}
return p, nil
})
Expand Down Expand Up @@ -56,6 +56,11 @@ func NewWithHTTPClient(apiKey string, client *http.Client) *Provider {
}
}

// SetBaseURL allows configuring a custom base URL for the provider
func (p *Provider) SetBaseURL(url string) {
p.baseURL = url
}

// Supports returns true if this provider can handle the given model
func (p *Provider) Supports(model string) bool {
return strings.HasPrefix(model, "gpt-") || strings.HasPrefix(model, "o1")
Expand Down