Add SetBaseURL setter methods for proper encapsulation#7
Merged
Conversation
Co-authored-by: SantiagoDePolonia <16936376+SantiagoDePolonia@users.noreply.github.com>
Added SetBaseURL() setter method to all providers (OpenAI, Anthropic, Gemini) to improve encapsulation instead of directly accessing private baseURL field. This addresses the code review feedback on maintaining better API boundaries. Co-authored-by: SantiagoDePolonia <16936376+SantiagoDePolonia@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update error standardization and refactor improvements
Add SetBaseURL setter methods for proper encapsulation
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider registration code directly accessed the private
baseURLfield, bypassing encapsulation:Changes:
SetBaseURL(url string)method to OpenAI, Anthropic, and Gemini providersinit()registration functions to use setter instead of direct field access💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Note
Adds
SetBaseURLto OpenAI, Anthropic, and Gemini providers and updates registration to use it; removesconfig/config.yaml.SetBaseURL(url string)tointernal/providers/openai/openai.go,internal/providers/anthropic/anthropic.go, andinternal/providers/gemini/gemini.go.SetBaseURL(cfg.BaseURL)instead of assigningbaseURLdirectly.config/config.yaml.Written by Cursor Bugbot for commit 216bb24. This will update automatically on new commits. Configure here.