Skip to content

ci: run the client_server test suite (enable __test-data in the matrix) #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ki Hyun Park (kihyun1998) wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −4
Open

ci: run the client_server test suite (enable __test-data in the matrix) #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5907f07
ci: run the client_server test suite (enable __test-data in the matrix)
kihyun1998 Jun 18, 2026
96d055b
test: initialize additional_service_keys in ServerProperties test setups
kihyun1998 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,18 @@ jobs:
- manifest: crates/dpapi-native-transport/Cargo.toml
crate-name: dpapi-native-transport

# Per-OS feature overrides for specific manifests
# Per-OS feature overrides for specific manifests.
# `__test-data` enables the `tests/sspi/client_server` suite (gated on
# `all(network_client, __test-data)`), which otherwise never runs in CI.
- os: win
manifest: Cargo.toml
additional-args: --features network_client,dns_resolver,scard,tsssp
additional-args: --features network_client,dns_resolver,scard,tsssp,__test-data
- os: osx
manifest: Cargo.toml
additional-args: --features network_client,scard
additional-args: --features network_client,scard,__test-data
- os: linux
manifest: Cargo.toml
additional-args: --features network_client,dns_resolver,scard
additional-args: --features network_client,dns_resolver,scard,__test-data

- os: win
manifest: ffi/Cargo.toml
Expand Down
1 change: 1 addition & 0 deletions tests/sspi/client_server/credssp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ fn credssp_kerberos() {
max_time_skew: MAX_TIME_SKEW,
ticket_decryption_key: None,
service_name: target_service_name,
additional_service_keys: Vec::new(),
user: Some(CredentialsBuffers::try_from(credentials.clone()).unwrap()),
client: None,
authenticators_cache: HashSet::new(),
Expand Down
4 changes: 4 additions & 0 deletions tests/sspi/client_server/kerberos/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ fn kerberos_auth() {
max_time_skew: MAX_TIME_SKEW,
ticket_decryption_key: Some(ticket_decryption_key.into()),
service_name: target_service_name,
additional_service_keys: Vec::new(),
user: None,
client: None,
authenticators_cache: HashSet::new(),
Expand Down Expand Up @@ -402,6 +403,7 @@ fn spnego_kerberos_u2u() {
max_time_skew: MAX_TIME_SKEW,
ticket_decryption_key: Some(ticket_decryption_key.into()),
service_name: target_service_name,
additional_service_keys: Vec::new(),
user: Some(credentials.clone()),
client: None,
authenticators_cache: HashSet::new(),
Expand Down Expand Up @@ -511,6 +513,7 @@ fn run_spnego(
max_time_skew: MAX_TIME_SKEW,
ticket_decryption_key: Some(ticket_decryption_key.into()),
service_name: target_service_name,
additional_service_keys: Vec::new(),
user: None,
client: None,
authenticators_cache: HashSet::new(),
Expand Down Expand Up @@ -742,6 +745,7 @@ fn spnego_kerberos_ntlm_fallback_spn_ip_address() {
max_time_skew: MAX_TIME_SKEW,
ticket_decryption_key: Some(ticket_decryption_key.into()),
service_name: target_service_name,
additional_service_keys: Vec::new(),
user: Some(credentials.clone()),
client: None,
authenticators_cache: HashSet::new(),
Expand Down