ci: run the client_server test suite (enable __test-data in the matrix)#691
Open
Ki Hyun Park (kihyun1998) wants to merge 2 commits into
Open
Conversation
The tests/sspi/client_server module is gated on all(network_client, __test-data), but no test-matrix row enabled __test-data, so the client<->server pairing tests (credssp_ntlm, credssp_kerberos, and the credssp_negotiate_ntlm regression test merged in Devolutions#689) never ran in CI. That gap is how Devolutions#687 shipped unnoticed. This adds __test-data to the three root-manifest matrix rows. The suite is hermetic (KdcMock / NetworkClientMock, no real network).
ServerProperties grew an additional_service_keys field; the __test-data client_server initializers were never updated because the suite does not compile in CI. Set it to Vec::new() (the library's own default in ServerProperties::new / fake_server_properties) - these tests use a single service, so no additional keys; behavior is unchanged.
Pavlo Myroniuk (TheBestTvarynka)
approved these changes
Jun 18, 2026
Pavlo Myroniuk (TheBestTvarynka)
requested a review
from Benoît Cortier (CBenoit)
Collaborator
|
Ki Hyun Park (@kihyun1998), thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tests/sspi/client_servermodule is gated onall(network_client, __test-data), but no test-matrix row enables__test-data— so the client↔server pairing tests (credssp_ntlm,credssp_kerberos, and thecredssp_negotiate_ntlmtest merged in #689) never run in CI. That gap is how #687 shipped unnoticed.Commit 1 — CI: add
__test-datato the three root-manifest matrix rows (win/osx/linux).Commit 2 — test fix the flip surfaced: with the suite finally compiling in CI, five
ServerPropertiesinitializers under__test-datawere missing theadditional_service_keysfield (added to the struct at some point, but the never-compiled test code wasn't updated). Set toVec::new()— the same default the library uses inServerProperties::new/fake_server_properties; these tests use a single service, so behavior is unchanged. Kept as a separate commit; it's a prerequisite the CI change reveals, not unrelated work.The suite is hermetic (
KdcMock/NetworkClientMock, no real network). Verified across the full win/osx/linux matrix — all green.Follow-up to #688 / #689.