Skip to content

Auto-activate cpp easy wins for no-code-owner #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dd-octo-sts wants to merge 1 commit into from
+10 −3
Closed

Auto-activate cpp easy wins for no-code-owner #6613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions manifests/cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ manifest:
- declaration: bug (APMAPI-866)
component_version: <=1.0.0
tests/parametric/test_dynamic_configuration.py::TestDynamicConfigTracingEnabled::test_tracing_client_tracing_disable_one_way: irrelevant (APMAPI-1592)
tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV1::test_log_injection_enabled: missing_feature (Tracer doesn't support automatic logs injection)
tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV1::test_log_injection_enabled: # TODO: a lower version might be supported
- declaration: missing_feature (Tracer doesn't support automatic logs injection)
component_version: <2.0.0
Comment on lines +84 to +86
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep log-injection test disabled until it validates feature

This change enables TestDynamicConfigV1::test_log_injection_enabled for C++ >=2.0.0, but the same manifest still marks TestDynamicConfigV2::test_capability_tracing_logs_injection as irrelevant (unsupported), and the test body itself only calls set_and_wait_rc(..., config_overrides={"tracing_sampling_rate": None}) instead of exercising log_injection_enabled. In cpp >=2.0.0 runs this can now report a pass without validating logs injection support, producing a false-positive activation signal rather than real coverage.

Useful? React with 👍 / 👎.

tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV1::test_trace_sampling_rate_override_env:
- declaration: bug (APMAPI-863)
component_version: <=1.0.0
Expand Down Expand Up @@ -285,11 +287,16 @@ manifest:
tests/parametric/test_trace_sampling.py::Test_Trace_Sampling_With_W3C::test_distributed_headers_synthetics_sampling_decision: bug (APMAPI-1563)
tests/parametric/test_tracer.py::Test_ProcessTags_ServiceName: missing_feature
tests/parametric/test_tracer.py::Test_Tracer::test_tracer_span_top_level_attributes: missing_feature (metrics cannot be set manually)
tests/parametric/test_tracer.py::Test_TracerBaseService: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerBaseService: # TODO: a lower version might be supported
- declaration: missing_feature (_dd.base_service is not implemented)
component_version: <2.0.0
tests/parametric/test_tracer.py::Test_TracerBaseService::test_base_service_set_when_service_overridden: missing_feature (_dd.base_service is not implemented)
tests/parametric/test_tracer.py::Test_TracerSCITagging: missing_feature
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_manual_service_name_sets_srv_src: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerServiceNameSource::test_tracer_no_srv_src_when_service_not_manually_set: irrelevant (Only implemented for Java)
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: "missing_feature (FIXME: library test client sets empty string as the service name)"
tests/parametric/test_tracer.py::Test_TracerUniversalServiceTagging::test_tracer_service_name_environment_variable: # TODO: a lower version might be supported
- declaration: 'missing_feature (FIXME: library test client sets empty string as the service name)'
component_version: <2.0.0
tests/parametric/test_tracer_flare.py: '>=2.0.0' # Modified by easy win activation script
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_flare_log_level_order: missing_feature # Created by easy win activation script
tests/parametric/test_tracer_flare.py::TestTracerFlareV1::test_no_tracer_flare_for_other_task_types: missing_feature # Created by easy win activation script
Expand Down
Loading