Auto-activate cpp easy wins for no-code-owner#6613
Auto-activate cpp easy wins for no-code-owner#6613dd-octo-sts[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cae748bc51
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV1::test_log_injection_enabled: # TODO: a lower version might be supported | ||
| - declaration: missing_feature (Tracer doesn't support automatic logs injection) | ||
| component_version: <2.0.0 |
There was a problem hiding this comment.
This change enables TestDynamicConfigV1::test_log_injection_enabled for C++ >=2.0.0, but the same manifest still marks TestDynamicConfigV2::test_capability_tracing_logs_injection as irrelevant (unsupported), and the test body itself only calls set_and_wait_rc(..., config_overrides={"tracing_sampling_rate": None}) instead of exercising log_injection_enabled. In cpp >=2.0.0 runs this can now report a pass without validating logs injection support, producing a false-positive activation signal rather than real coverage.
Useful? React with 👍 / 👎.
Automated activation of easy-win tests for
cppowned byno-code-ownerView nightly workflow run