Skip to content

Created workflow for actually running code coverage#23

Open
ben18785 wants to merge 2 commits into
masterfrom
i9-code-coverage
Open

Created workflow for actually running code coverage#23
ben18785 wants to merge 2 commits into
masterfrom
i9-code-coverage

Conversation

@ben18785

@ben18785 ben18785 commented Mar 3, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@fcooper8472

Copy link
Copy Markdown

Unless there's a good reason to run these on macOS-latest I would definitely run them on ubuntu-latest: they have much more availability and spin up faster. You quite often have to wait while a macos runner becomes available.

@ben18785

ben18785 commented Mar 3, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks @fcooper8472 Have changed it to that.

Interesting codecov is failing here because we don't have any functions to test! So, I'd suggest we wait before merging this in, perhaps?

@fcooper8472

Copy link
Copy Markdown

Probably a good plan!

Or put in a silly dummy function & test just to satisfy yourself that it's all good to go as soon as there's real functionality?

@ben18785

ben18785 commented Mar 3, 2021

Copy link
Copy Markdown
Collaborator Author

I ran it with a dummy function on my local machine and codecov then worked. So think we're ok (just afraid that I'd forget to remove said dummy function). Hopefully we'll have some functions to test in the next few days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants