Skip to content

Linting and autmated checking#31

Merged
rccreswell merged 13 commits into
masterfrom
i28-style
Mar 5, 2021
Merged

Linting and autmated checking#31
rccreswell merged 13 commits into
masterfrom
i28-style

Conversation

@alisterde

@alisterde alisterde commented Mar 4, 2021

Copy link
Copy Markdown

Implementing automating linting check to workflow (this pull requested will check if I have set this up correctly), and adding linting instructions to README. As issue #28

@alisterde alisterde marked this pull request as ready for review March 4, 2021 17:51
@alisterde alisterde requested review from ben18785 and rccreswell March 4, 2021 17:51

@rccreswell rccreswell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very helpful, thanks @alisterde

Comment thread .github/workflows/lint.yaml
Comment thread README.md Outdated
ben18785
ben18785 previously approved these changes Mar 5, 2021

@ben18785 ben18785 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alisterde -- once you've addressed @rcw5890 's concerns, I'm happy for this to go in.

Comment thread README.md Outdated

@rccreswell rccreswell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new readme comments look great, but there's now an unnecessary table appearing at the top of the readme here
@ben18785 I think you figured out how to prevent this?

@alisterde

Copy link
Copy Markdown
Author

Thanks @rcw5890! I think the readme my table might be from knitr::knit("README.Rmd"), I've tried something. I've also noticed there was a formatting error with the bullet points of the style guide, though it was fine when I was previewing it. Also thanks for looking at the automated Ubuntu release lint testing, it's quite frustrating!

@alisterde

Copy link
Copy Markdown
Author

Hi @rcw5890 the table is now gone from the top of the readme, and the bullet points are correctly formatted.

@rccreswell

Copy link
Copy Markdown
Contributor

Thanks @alisterde this looks ready to go.

Also thanks for looking at the automated Ubuntu release lint testing, it's quite frustrating!

It definitely is. I suspect there is some way to fix it, but I am in favor of merging this now so any imminent code contributions get checked properly.

@rccreswell rccreswell merged commit cd53958 into master Mar 5, 2021
@rccreswell rccreswell deleted the i28-style branch March 5, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants