Support rendering for all glTF primitive modes#702
Merged
Conversation
Merged
14 tasks
14 tasks
Contributor
Author
|
Updated for CesiumGS/cesium-native#1393; turns out that Unity doesn't like when we pass in an index buffer with the primitive restart value (it crashes at This is ready for review! |
Contributor
|
Thanks @j9liu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #701 so merge that first.Depends on CesiumGS/cesium-native#1393.
This PR incorporates the above cesium-native PR to render all primitive modes in Unity. Since not all modes are supported out-of-the-box, this uses options in
LoadTilesetto make cesium-native retopologize as needed.LINE_LOOPLINE_STRIPTRIANGLE_STRIPTRIANGLE_FANAuthor checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.[ ] I have updated the documentation as necessary.Testing plan
01_CesiumWorldCesiumGeoreferencecomponent.tileset.jsonto change the URL of the referenced.glb.Confirm that the model matches the above appearance.
Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.