Handle primitive restart when re-topologizing primitives#1393
Merged
Conversation
This was referenced Jun 23, 2026
Contributor
|
Thanks @j9liu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1392, so merge that first.
This PR accounts for primitive restart constants when converting
LINE_LOOP,LINE_STRIP,TRIANGLE_STRIP, andTRIANGLE_FANtopology. This would support the consumption of primitives withKHR_mesh_primitive_restart.Issue number or link
Closes #1321.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Testing plan
cesium-nativeto retopologize unsupported primitive modes cesium-unreal#1854Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.