Skip to content

Handle primitive restart when re-topologizing primitives#1393

Merged
azrogers merged 7 commits into
mainfrom
primitive-restart
Jun 23, 2026
Merged

Handle primitive restart when re-topologizing primitives#1393
azrogers merged 7 commits into
mainfrom
primitive-restart

Conversation

@j9liu

@j9liu j9liu commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Depends on #1392, so merge that first.

This PR accounts for primitive restart constants when converting LINE_LOOP, LINE_STRIP, TRIANGLE_STRIP, and TRIANGLE_FAN topology. This would support the consumption of primitives with KHR_mesh_primitive_restart.

Issue number or link

Closes #1321.

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu j9liu changed the base branch from main to convert-primitive-mode June 15, 2026 19:45
@j9liu j9liu added this to the July 2026 Release milestone Jun 16, 2026
@j9liu j9liu force-pushed the primitive-restart branch from c1ba116 to 2df1c19 Compare June 17, 2026 18:14
@j9liu j9liu marked this pull request as ready for review June 23, 2026 18:36
@j9liu j9liu requested a review from azrogers June 23, 2026 18:57
Base automatically changed from convert-primitive-mode to main June 23, 2026 20:31
@azrogers azrogers merged commit 7c699d1 into main Jun 23, 2026
28 checks passed
@azrogers azrogers deleted the primitive-restart branch June 23, 2026 21:13
@azrogers

Copy link
Copy Markdown
Contributor

Thanks @j9liu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assess support for KHR_mesh_primitive_restart

2 participants