Skip to content

security: fix broken access control in question endpoints #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaranUnique merged 1 commit into from
Jun 2, 2026
Merged

security: fix broken access control in question endpoints #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions backend/controllers/questionController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,21 @@ const togglePinQuestion = async (req, res) => {
.status(404)
.json({ success: false, message: "Question not found" });
}

const session = await Session.findById(question.session);
if (!session) {
return res
.status(404)
.json({ success: false, message: "Session not found" });
}

if (session.user.toString() !== req.user.id) {
return res.status(403).json({
success: false,
message: "Unauthorized access",
});
}

question.isPinned = !question.isPinned;
await question.save();

Expand Down Expand Up @@ -104,6 +119,21 @@ const updateQuestionNote = async (req, res) => {
.status(404)
.json({ success: false, message: "Question not found" });
}

const session = await Session.findById(question.session);
if (!session) {
return res
.status(404)
.json({ success: false, message: "Session not found" });
}

if (session.user.toString() !== req.user.id) {
return res.status(403).json({
success: false,
message: "Unauthorized access",
});
}

question.note = note || "";
await question.save();

Expand Down