security: fix broken access control in question endpoints#51
Open
joydip7 wants to merge 1 commit into
Open
Conversation
joydip7
force-pushed
the
fix/broken-access-control
branch
from
1fbf54c to
d23d5d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a broken access control (IDOR) vulnerability in the question controller. Specifically, in
togglePinQuestionandupdateQuestionNote, any authenticated user could modify pins or notes for questions belonging to other users if they knew the question ID.Changes
togglePinQuestionandupdateQuestionNoteto load the question's session and verify that the session user ID matches the authenticated user ID (req.user.id).403 Forbiddenresponse withUnauthorized accessis returned.backend/scripts/verify_vulnerability.jsto reproduce and confirm the fix.Documentation about the fix->
questionAuth fix.pdf