Dark Mode#58
Conversation
|
|
@dipenp495: Why did you merge the old branch into this one? I specifically created this branch to not create a tangled merge with the old branch. Please stop. I will go through and pick this apart later. |
|
@mrysav Sorry for the confusion here. I asked you earlier if I could commit a few fixes for dark mode, and you agreed, so I went ahead and pushed them. I understand the concern about keeping this branch clean though, so I can remove my commit from the branch. Also, this branch is missing a few dark mode updates, which is what I was trying to address. |
…dal, claimed products, copy/delete popups, admin charts
7465885 to
3aa6a20
Compare
|
@dipenp495 I see. I'm sorry for my comment earlier. I did a I find it pretty hard to review React code the start with and I am trying to keep a fairly logical commit history here since the dark mode changes are fairly intrusive, and I've been going commit by commit to review the changes. Additionally, and importantly, I wanted to restrict this only to dark mode and not have other changes slip in, so I can review those independently. I think we should be good to merge this. |
mrysav
left a comment
There was a problem hiding this comment.
Did a review, pulled the code, and I'm happy with the results. @iamsrijan724 @kierstinhicks @dipenp495 I'm going to merge this branch - any future work can be its own PR! Thanks!
Rebases #28 from
mainand does not merge fromstagingorfeat-supplier-dashboardThis was a fair bit of manual work to try and pick out the relevant commits from the other branch to isolate them into this branch, and I think I likely missed some. However, everyone's authorship on their respective commits should be preserved.