Initial Dark mode Implementation#28
Conversation
kierstinhicks
left a comment
There was a problem hiding this comment.
hi srijan, looks good! approved
TrickkyRicky
left a comment
There was a problem hiding this comment.
Hey guys I like the color but could we update the titles to be white so that they contrast better with the background(ADMIN Page)
It also looks like you guys didn't add the dark mode colors to the Nonprofit page nor the Supplier change but some of the changes you made affect the other pages. Could you also update those to show the proper dark mode colors as well
|
Hi @TrickkyRicky thanks for the feedback. Great points. @iamsrijan724 we can work to make these updates this week |
|
Hi Ricky,Thanks! We were thinking of just getting these changes merged in and then next week we can do these more detailed changes. Is that okay? Sent from my iPhoneOn Mar 16, 2026, at 7:00 AM, kierstinhicks ***@***.***> wrote:kierstinhicks left a comment (C4G/AtlantaFoodConsortium#28)
Hi @TrickkyRicky thanks for the feedback. Great points. @iamsrijan724 we can work to make these updates this week
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I won’t be able to do any development tasks until Thursday since I am traveling for work. I think if we merge it in as is, we can have basic dark mode functionality for the peer evaluation. Sent from my iPhoneOn Mar 16, 2026, at 7:06 AM, Srijan Srivatsa ***@***.***> wrote:Hi Ricky,Thanks! We were thinking of just getting these changes merged in and then next week we can do these more detailed changes. Is that okay? Sent from my iPhoneOn Mar 16, 2026, at 7:00 AM, kierstinhicks ***@***.***> wrote:kierstinhicks left a comment (C4G/AtlantaFoodConsortium#28)
Hi @TrickkyRicky thanks for the feedback. Great points. @iamsrijan724 we can work to make these updates this week
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@iamsrijan724, @kierstinhicks |
|
Okay, in that case probably better to leave dark mode off of the peer evaluation. Sent from my iPhoneOn Mar 16, 2026, at 11:44 AM, Richard Young ***@***.***> wrote:TrickkyRicky left a comment (C4G/AtlantaFoodConsortium#28)
I won’t be able to do any development tasks until Thursday since I am traveling for work. I think if we merge it in as is, we can have basic dark mode functionality for the peer evaluation. Sent from my iPhoneOn Mar 16, 2026, at 7:06 AM, Srijan Srivatsa @.> wrote:Hi Ricky,Thanks! We were thinking of just getting these changes merged in and then next week we can do these more detailed changes. Is that okay? Sent from my iPhoneOn Mar 16, 2026, at 7:00 AM, kierstinhicks @.> wrote:kierstinhicks left a comment (C4G/AtlantaFoodConsortium#28) Hi @TrickkyRicky thanks for the feedback. Great points. @iamsrijan724 we can work to make these updates this week —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
@iamsrijan724, @kierstinhicks
The issue should represent the full completion of the work. The dark mode is inconsistent with the other elements on the page and it also affects other pages other than admin. It may be better to go without this feature on the survey since its incomplete
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@iamsrijan724 @kierstinhicks @TrickkyRicky Agreed - if dark mode makes the text illegible, unfortunately, we probably shouldn't merge this into the main branch. It is still OK to merge things into the |
|
Hi all - |
Branched from doc wesley for stage
…xes-stage Feat miscellaneous changes and bug fixes stage
…into feat-add-partial-nonprofit-claims-staging
…ging Feat add partial nonprofit claims staging
nhance supplier dashboard with drill-down KPIs, sortable tables, and …
…into feat-announcement-discussion-notifier-stage
…-stage Feat announcement discussion notifier stage
49c920b to
464e472
Compare
|
Dark Mode
Supplier Dashboard
|
|
@dipenp495 Merging all of those commits into this branch has unfortunately made it quite difficult to review and merge, and additionally, merging I reopened a new PR with just the dark mode changes, or at least, I hope most of them: #58. Let's please review and get that one merged. @iamsrijan724 @kierstinhicks Please make finishing that PR your priority. @dipenp495 Please direct your additional work to your other supplier dashboard PR. |



Initial functionality of dark mode! Please test locally to make sure dark mode is appearing on all pages. Next week, will nitpick and make it better (ex. some of the text on charts could be more readable).