Add TIMED_TEST_DEFAULT_TIMEOUT_MS argument to all TIMED_TEST_SUITE_INITIALIZE calls#545
Closed
parth21999 wants to merge 3 commits intomasterfrom
Closed
Add TIMED_TEST_DEFAULT_TIMEOUT_MS argument to all TIMED_TEST_SUITE_INITIALIZE calls#545parth21999 wants to merge 3 commits intomasterfrom
parth21999 wants to merge 3 commits intomasterfrom
Conversation
…ITIALIZE calls All test files were using TIMED_TEST_SUITE_INITIALIZE(name) with only one argument. The macro requires a timeout_ms parameter. This adds TIMED_TEST_DEFAULT_TIMEOUT_MS (10 minutes) as the second argument to all 88 test files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 2, 2026
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Added the include to 102 PCH files and 36 integration/perf test files. Without this include, TIMED_TEST_SUITE_INITIALIZE is undefined and the compiler emits C2220 errors (warning treated as error). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The include must be before ENABLE_MOCKS to prevent process_watchdog functions from being mocked, which causes unresolved external symbol linker errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Superseded by new PR based on master (without testrunnerswitcher changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 88 test files were using
TIMED_TEST_SUITE_INITIALIZE(name)with only one argument. The macro requires atimeout_msparameter as the second argument. This addsTIMED_TEST_DEFAULT_TIMEOUT_MS(10 minutes) to all calls.Changes
Mechanical replacement across 100 files:
TIMED_TEST_SUITE_INITIALIZE(name)->TIMED_TEST_SUITE_INITIALIZE(name, TIMED_TEST_DEFAULT_TIMEOUT_MS)No logic changes. No include changes (
c_pal/timed_test_suite.hwas already included).Prerequisites