Convert all tests to use TIMED_TEST_SUITE_INITIALIZE/CLEANUP#583
Open
parth21999 wants to merge 2 commits intomasterfrom
Open
Convert all tests to use TIMED_TEST_SUITE_INITIALIZE/CLEANUP#583parth21999 wants to merge 2 commits intomasterfrom
parth21999 wants to merge 2 commits intomasterfrom
Conversation
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5ae2b01 to
4e0b5f9
Compare
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tests using TIMED_TEST_SUITE_INITIALIZE need to link against c_pal for the process_watchdog_init/deinit implementations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts all 65 test files from TEST_SUITE_INITIALIZE/TEST_SUITE_CLEANUP to TIMED_TEST_SUITE_INITIALIZE/TIMED_TEST_SUITE_CLEANUP. Adds c_pal/timed_test_suite.h to 49 PCH files and 17 integration test files.
Why
The timed versions inject a process watchdog that terminates test suites that hang, preventing CI pipelines from stalling indefinitely. The raw TEST_SUITE_INITIALIZE/CLEANUP macros are being removed from testrunnerswitcher.
Prerequisites