Skip to content

Jbaker/update hyperlink styles #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason-capsule42 merged 3 commits into from
May 28, 2026
Merged

Jbaker/update hyperlink styles #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe99864
ci: use modern style linting
jason-capsule42 May 27, 2026
99da9bb
fix: update link classes to match current auro-hyperkink
jason-capsule42 May 27, 2026
c4ec60f
fix: resolve deprecation errors and build issues
jason-capsule42 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/assets/css/main.css
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion docs/assets/css/main.css.map
View file
Open in desktop

This file was deleted.

416 changes: 233 additions & 183 deletions docs/index.html
View file
Open in desktop

Large diffs are not rendered by default.

11,364 changes: 5,374 additions & 5,990 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"sass": "^1.42.1"
},
"dependencies": {
"@aurodesignsystem/design-tokens": "^8.18.0",
"@aurodesignsystem/design-tokens": "^8.19.0",
"chalk": "^5.4.1"
},
"devDependencies": {
Expand All @@ -42,14 +42,15 @@
"sass-true": ">=6.1.0",
"sassdoc": "^2.7.3",
"semantic-release": "^24.2.1",
"postcss-scss": "^4.0.9",
"stylelint": ">=13.13.1",
"stylelint-config-recommended": ">=5.0.0",
"stylelint-config-standard": ">=22.0.0"
},
"scripts": {
"copy:files": "copyfiles -u 1 -V './src/auroElement/**/*' ./dist",
"css:lint": "stylelint './results/css/*.css'",
"scss:lint": "stylelint './src/**/*.scss'",
"scss:lint": "stylelint './src/**/*.scss' --custom-syntax postcss-scss",
"build": "npm-run-all build:sassdoc build:sass:demo build:dist-bundle copy:files postinstall",
"build:dist-bundle": "npm-run-all build:type-classes-css build:theme-css",
"build:theme-css": "node scripts/theme.global.css.build.mjs",
Expand All @@ -62,7 +63,7 @@
"sweep": "rm -rf ./dist ./results ./sassdoc",
"postinstall": "node packageScripts/postinstall.mjs",
"jest": "jest",
"test": "npm-run-all jest",
"test": "npm-run-all scss:lint build:sass:test css:lint jest",
"serve": "npm run build:sassdoc && node scripts/live-server.js",
"watch": "nodemon -e scss --watch tests --watch src --exec npm run build:dev",
"prepare": "husky"
Expand Down
8 changes: 4 additions & 4 deletions src/_grids.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@ $fixed-anchor-width: 168px;
@include grid_margin();
@include grid_padding(vac.$ds-grid-margin-xs);
@include grid_width(vac.$ds-grid-breakpoint-xl);
@include grid_gutter(vac.$ds-grid-gutter-xl);
grid-template-areas:
"breadcrumbs"
"anchornav"
"main";
@include grid_gutter(vac.$ds-grid-gutter-xl);

@include auro_grid-breakpoint--sm {
@include grid_padding(vac.$ds-grid-margin-sm);
Expand Down Expand Up @@ -250,11 +250,11 @@ $fixed-anchor-width: 168px;
@include grid_margin();
@include grid_padding(0);
@include grid_width(vac.$ds-grid-breakpoint-xl);
@include grid_gutter(vac.$ds-grid-gutter-xl);
grid-template-areas:
"breadcrumbs"
"sidenav"
"main";
@include grid_gutter(vac.$ds-grid-gutter-xl);


@include auro_grid-breakpoint--md {
Expand Down Expand Up @@ -327,12 +327,12 @@ $fixed-anchor-width: 168px;
@include grid_margin();
@include grid_padding(0);
@include grid_width(vac.$ds-grid-breakpoint-xl);
@include grid_gutter(vac.$ds-grid-gutter-xl);
grid-template-areas:
"breadcrumbs"
"sidenav"
"anchornav"
"main";
@include grid_gutter(vac.$ds-grid-gutter-xl);


@include auro_grid-breakpoint--md {
Expand Down Expand Up @@ -386,8 +386,8 @@ $fixed-anchor-width: 168px;

.anchornav {
grid-area: anchornav;
@include grid-stickycolumn--md;
@include grid_padding(vac.$ds-grid-margin-xs);
@include grid-stickycolumn--md;

@include auro_grid-breakpoint--md {
@include grid_padding(0);
Expand Down
4 changes: 2 additions & 2 deletions src/componentSupport/_anchor-roleTab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/// @example scss - import selector file
/// @import "./node_modules/@aurodesignsystem/webcorestylesheets/dist/componentSupport/anchor-roleTab";
#{$scope}.auro_roleTab {
@include auro_anchorTab(sass, noncomponent);

margin-right: calc(#{$ds-size-50} * -1);
Comment thread
jason-capsule42 marked this conversation as resolved.

@include auro_anchorTab(sass, noncomponent);
}
12 changes: 6 additions & 6 deletions src/componentSupport/_tablist.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@
/// @import "./node_modules/@aurodesignsystem/webcorestylesheets/dist/componentSupport/tablist";

#{$scope}.auro_tablist {
@include auro_breakpoint($min: $ds-grid-breakpoint-sm) {
overflow-y: unset;

white-space: unset;
}

overflow-y: scroll;

height: calc(#{$ds-size-600} + 1px);
Expand All @@ -34,4 +28,10 @@
border-color: var(--ds-color-border-primary-default, $ds-color-border-primary-default);

line-height: var(--ds-size-600, $ds-size-600);

@include auro_breakpoint($min: $ds-grid-breakpoint-sm) {
overflow-y: unset;

white-space: unset;
}
}
3 changes: 3 additions & 0 deletions src/config/alaska/base/essentials.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ $alaska-base-config: (
'hyperlink-hover-color': $ds-advanced-color-hyperlink-text-hover,
'hyperlink-inverse-color': $ds-advanced-color-hyperlink-text-inverse,
'hyperlink-inverse-hover-color': $ds-advanced-color-hyperlink-text-inverse-hover,
'focus-color': $ds-advanced-color-state-focused,
'focus-offset': $ds-size-25,
'focus-width': $ds-size-50,
'small-font-size': $ds-type-size-12,
'small-font-weight': $ds-type-weight-book,
'small-line-height': $ds-type-line-height-px-16,
Expand Down
1 change: 1 addition & 0 deletions src/config/alaska/base/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "@aurodesignsystem/design-tokens/dist/themes/alaska/SCSSVariables--alaska";
@import "@aurodesignsystem/design-tokens/dist/legacy/auro-classic/SCSSVariables";

// Alaska Base Configs
@import "essentials";
1 change: 1 addition & 0 deletions src/config/auro-1/base/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "@aurodesignsystem/design-tokens/dist/themes/auro-1/SCSSVariables--auro1";
@import "@aurodesignsystem/design-tokens/dist/legacy/auro-classic/SCSSVariables";

// Auro-1 Base Configs - uses Alaska base essentials with Auro-1 design tokens
@import "../../alaska/base/essentials";
3 changes: 3 additions & 0 deletions src/config/hawaiian/base/essentials.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ $hawaiian-base-config: (
'hyperlink-hover-color': $ds-advanced-color-hyperlink-text-hover,
'hyperlink-inverse-color': $ds-advanced-color-hyperlink-text-inverse,
'hyperlink-inverse-hover-color': $ds-advanced-color-hyperlink-text-inverse-hover,
'focus-color': $ds-advanced-color-state-focused,
'focus-offset': $ds-size-25,
'focus-width': $ds-size-50,
'small-font-size': $ds-type-size-12,
'small-font-weight': $ds-type-weight-regular,
'small-line-height': $ds-type-line-height-px-16,
Expand Down
3 changes: 2 additions & 1 deletion src/config/hawaiian/base/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "../../../../node_modules/@aurodesignsystem/design-tokens/dist/themes/hawaiian/SCSSVariables--hawaiian";
@import "@aurodesignsystem/design-tokens/dist/themes/hawaiian/SCSSVariables--hawaiian";
@import "@aurodesignsystem/design-tokens/dist/legacy/auro-classic/SCSSVariables";

// Hawaiian Base Configs
@import "essentials";
4 changes: 0 additions & 4 deletions src/elementDemoStyles/elementDemoStyles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
@extend .heading--500;
}

a {
@extend .hyperlink;
}

p {
@extend p;

Expand Down
36 changes: 26 additions & 10 deletions src/essentials/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,51 @@ $paragraph: null !default;

/// Baseline hyperlink styles as mirrored in auro-hyperlink web component
#{$scope}.#{$prefix}hyperlink {
transition: all .15s ease;
text-decoration: underline;
color: map-get($theme-props, 'hyperlink-color');
border-radius: 3px;
outline-offset: unset;
outline-style: solid;
outline-width: 1px;
outline-color: transparent;

&:visited {
color: map-get($theme-props, 'hyperlink-color');
}

&:focus-visible {
outline-color: map-get($theme-props, 'focus-color');
outline-offset: map-get($theme-props, 'focus-offset');
}

@media (hover: hover) {
&:hover {
text-decoration: none;
color: map-get($theme-props, 'hyperlink-hover-color');
}
}

&--nav {
display: block;
text-decoration: none;

&:not(.is-touching) {
@media (hover: hover) {
&:hover {
text-decoration: underline !important;
text-decoration: underline;
}
}

&:focus-visible {
outline-width: map-get($theme-props, 'focus-width');
outline-offset: unset;
}
}

&--ondark {
color: map-get($theme-props, 'hyperlink-inverse-color');

&:not(.is-touching) {
@media (hover: hover) {
&:hover {
color: map-get($theme-props, 'hyperlink-inverse-hover-color');
}
Expand All @@ -90,13 +113,6 @@ $paragraph: null !default;
color: map-get($theme-props, 'hyperlink-inverse-color');
}
}

&:not(.is-touching) {
&:hover {
text-decoration: none;
color: map-get($theme-props, 'hyperlink-hover-color');
}
}
}

/// Default setting for all `<img />` tags
Expand Down
55 changes: 36 additions & 19 deletions src/essentials/legacy/_auro-classic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,47 +123,64 @@
///
/// @example scss - import file
/// @import "./node_modules/@aurodesignsystem/webcorestylesheets/dist/essentials";
///
#{$scope}.#{$prefix}hyperlink {
transition: all .15s ease;
text-decoration: underline;

color: var(--ds-color-text-ui-default-default, $ds-color-text-ui-default-default);
color: var(--ds-advanced-color-hyperlink-text-hover);
border-radius: 3px;
outline-offset: unset;
outline-style: solid;
outline-width: 1px;
outline-color: transparent;

&:visited {
color: var(--ds-color-text-ui-default-default, $ds-color-text-ui-default-default);
color: var(--ds-advanced-color-hyperlink-text, $ds-color-text-ui-default-default);
}
Comment thread
jason-capsule42 marked this conversation as resolved.

&:focus-visible {
outline-color: var(--ds-advanced-color-state-focused, $ds-color-border-ui-focus-default);
outline-offset: var(--ds-size-25, $ds-size-25);
}

@media (hover: hover) {
&:hover {
text-decoration: none;
color: var(--ds-advanced-color-hyperlink-text-hover);
}
}

&:focus-visible {
outline-color: var(--ds-color-border-ui-focus-default, $ds-color-border-ui-focus-default);
outline-offset: var(--ds-size-25, $ds-size-25);
}

Comment thread
jason-capsule42 marked this conversation as resolved.
&--nav {
display: block;

text-decoration: none;

&:not(.is-touching) {
@media (hover: hover) {
&:hover {
text-decoration: underline !important;
text-decoration: underline;
}
}

&:focus-visible {
outline-width: var(--ds-size-50, $ds-size-50);
outline-offset: unset;
}
}

&--ondark {
color: var(--ds-color-text-ui-default-inverse, $ds-color-text-ui-default-inverse);
color: var(--ds-advanced-color-hyperlink-text-inverse);

&:not(.is-touching) {
@media (hover: hover) {
&:hover {
color: var(--ds-color-text-ui-hover-inverse, $ds-color-text-ui-hover-inverse);
color: var(--ds-advanced-color-hyperlink-text-inverse-hover);
}
}

&:visited {
color: var(--ds-color-text-ui-default-inverse, $ds-color-text-ui-default-inverse);
}
}

&:not(.is-touching) {
&:hover {
text-decoration: none;

color: var(--ds-color-text-ui-hover-default, $ds-color-text-ui-hover-default);
color: var(--ds-color-text-ui-default-inverse);
}
}
}
Expand Down
Loading
Loading