Jbaker/update hyperlink styles#286
Conversation
Reviewer's GuideUpdates core hyperlink styling and focus behavior across classic and theme-based styles, aligns docs to v11.0.0, and adjusts layout/grid utilities and tooling to support the new styles and SCSS linting. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The base and legacy
#{$scope}.#{$prefix}hyperlinkrules now contain nearly identical focus and hover logic; consider extracting a shared mixin so the behavior stays in sync and is easier to maintain. - The new
transition: all .15s easeon hyperlinks will animate every property including focus outlines; consider limiting the transition to specific properties (e.g.,color,text-decoration) to avoid delaying or animating critical focus states. - The new design-token imports mix package-style paths (e.g.,
@aurodesignsystem/...) with deep relative../../../../node_modules/...paths across the base configs; it may be clearer and more robust to standardize on a single import style.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The base and legacy `#{$scope}.#{$prefix}hyperlink` rules now contain nearly identical focus and hover logic; consider extracting a shared mixin so the behavior stays in sync and is easier to maintain.
- The new `transition: all .15s ease` on hyperlinks will animate every property including focus outlines; consider limiting the transition to specific properties (e.g., `color`, `text-decoration`) to avoid delaying or animating critical focus states.
- The new design-token imports mix package-style paths (e.g., `@aurodesignsystem/...`) with deep relative `../../../../node_modules/...` paths across the base configs; it may be clearer and more robust to standardize on a single import style.
## Individual Comments
### Comment 1
<location path="src/componentSupport/_anchor-roleTab.scss" line_range="23" />
<code_context>
/// @example scss - import selector file
/// @import "./node_modules/@aurodesignsystem/webcorestylesheets/dist/componentSupport/anchor-roleTab";
#{$scope}.auro_roleTab {
- @include auro_anchorTab(sass, noncomponent);
-
margin-right: calc(#{$ds-size-50} * -1);
</code_context>
<issue_to_address>
**issue (bug_risk):** Reordering the mixin after `margin-right` may cause the mixin to override your negative margin.
Previously the mixin ran first and the explicit `margin-right` overrode any margin set by `auro_anchorTab`. With the new order, if the mixin sets `margin`/`margin-right`, it will override your negative margin. If you need to guarantee this negative margin, keep the mixin before the `margin-right` declaration or adjust the mixin to avoid conflicting margin rules.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
768909a to
6b258d8
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates hyperlink styling and related theme configuration to align baseline link behavior with the auro-hyperlink component, including focus and hover treatment, while also adjusting SCSS lint parsing and regenerating SassDoc assets.
Changes:
- Updates themed and legacy hyperlink styles with underline, hover, focus-visible, nav, and on-dark behavior.
- Adds focus-related theme map values and imports token variables needed by those configs.
- Adjusts SCSS ordering in support/grid files and updates stylelint to parse SCSS via
postcss-scss.
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/essentials/legacy/_auro-classic.scss |
Updates legacy hyperlink styling and variants. |
src/essentials/_base.scss |
Updates themed baseline hyperlink mixin behavior. |
src/elementDemoStyles/elementDemoStyles.scss |
Removes markdown anchor extension to .hyperlink. |
src/config/hawaiian/base/index.scss |
Adds legacy token variable import for Hawaiian base config. |
src/config/hawaiian/base/essentials.scss |
Adds focus token values to Hawaiian base map. |
src/config/auro-1/base/index.scss |
Adds legacy token variable import for Auro-1 base config. |
src/config/alaska/base/index.scss |
Adds legacy token variable import for Alaska base config. |
src/config/alaska/base/essentials.scss |
Adds focus token values to Alaska base map. |
src/componentSupport/_tablist.scss |
Reorders breakpoint block after declarations. |
src/componentSupport/_anchor-roleTab.scss |
Reorders margin declaration before mixin include. |
src/_grids.scss |
Reorders grid mixin includes relative to declarations. |
package.json |
Adds postcss-scss and configures SCSS lint command with custom syntax. |
docs/assets/css/main.css.map |
Removes generated SassDoc source map. |
docs/assets/css/main.css |
Regenerates SassDoc stylesheet output. |
Files not reviewed (1)
- docs/assets/css/main.css: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
295caba to
ba6931e
Compare
|
🚀 PR Release Published! To install: npm install @aurodesignsystem-dev/webcorestylesheets@0.0.0-pr286.1Install via alias: npm install @aurodesignsystem@npm:@aurodesignsystem-dev/webcorestylesheets@0.0.0-pr286.1 |
ba6931e to
c4ec60f
Compare
|
🎉 This PR is included in version 11.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update core hyperlink styling and theme configuration to align with the auro-hyperlink component and improve accessibility, while adjusting layout utilities and build tooling for SCSS linting and theme imports.
Enhancements:
Build: