feat: Mock observation of brightness temperature by DanielaBreitman · Pull Request #49 · 21cmfast/tuesday

DanielaBreitman · 2025-09-10T16:17:19Z

Closes #48.

review-notebook-app · 2025-09-10T16:17:24Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

for more information, see https://pre-commit.ci

codecov · 2025-09-12T08:21:21Z

Codecov Report

❌ Patch coverage is 67.67677% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.95%. Comparing base (7480d86) to head (9fcd546).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tuesday/core/instrument_models/noise.py	67.67%	17 Missing and 15 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   85.44%   82.95%   -2.50%     
==========================================
  Files          11       11              
  Lines         742      827      +85     
  Branches      188      206      +18     
==========================================
+ Hits          634      686      +52     
- Misses         44       62      +18     
- Partials       64       79      +15

Flag	Coverage Δ
unittests	`82.95% <67.67%> (-2.50%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

for more information, see https://pre-commit.ci

steven-murray

OK, I got through most of it and it looks decent, but got super confused on some important stuff. When that gets cleared up I'll have a better look at the example notebooks.

src/tuesday/core/instrument_models/noise.py

steven-murray · 2025-09-12T11:33:02Z

src/tuesday/core/instrument_models/noise.py

+        sigma is set to zero for uv cells with less than
+        this number of baselines.


Technically, I think sigma should be set to np.inf... if in the end we do want to do inverse-variance weighting, np.inf will make this seamless.

src/tuesday/core/instrument_models/noise.py

for more information, see https://pre-commit.ci

src/tuesday/core/instrument_models/noise.py

for more information, see https://pre-commit.ci

steven-murray · 2025-09-15T06:33:54Z

@nikos-triantafyllou and @DanielaBreitman I made some substantial updates on this PR, adding a lot of documentation and also changing some of the function names to be more clear.

@nikos-triantafyllou I'd be grateful if you could have another play with it -- the main example notebook has been updated to give you a head-start. But it only uses artificial lightcones, not realistic ones, so it would be good to have a look at those to catch any obvious errors.

Also, you'll need rasg-affiliates/21cmSense#215 to run this.

docs/tutorials/lc_noise_compare_tools21cm.ipynb

…ing positive k_parallel

for more information, see https://pre-commit.ci

Fix 2 wedge removal bugs: Unnecessary Fourier shifting and only removing positive k_parallel

review-notebook-app · 2026-03-29T14:27:00Z

View / edit / reply to this conversation on ReviewNB

DanielaBreitman commented on 2026-03-29T14:27:00Z
----------------------------------------------------------------

Formatting (:mod:)

review-notebook-app · 2026-03-29T14:27:01Z

View / edit / reply to this conversation on ReviewNB

DanielaBreitman commented on 2026-03-29T14:27:00Z
----------------------------------------------------------------

Formatting

review-notebook-app · 2026-03-29T14:27:01Z

View / edit / reply to this conversation on ReviewNB

DanielaBreitman commented on 2026-03-29T14:27:01Z
----------------------------------------------------------------

Formatting (##)

review-notebook-app · 2026-03-29T14:27:02Z

View / edit / reply to this conversation on ReviewNB

DanielaBreitman commented on 2026-03-29T14:27:02Z
----------------------------------------------------------------

Formatting (##)

review-notebook-app · 2026-03-29T14:27:03Z

View / edit / reply to this conversation on ReviewNB

DanielaBreitman commented on 2026-03-29T14:27:02Z
----------------------------------------------------------------

Extra \ after "chosen at random"

DanielaBreitman

Very minor comments. Main thing to fix is tests. Besides that, things seem good (though I can't approve my own PR...)

DanielaBreitman · 2026-03-29T14:30:14Z

devel/test_out_jordans_problem.ipynb

Does this file actually belong in this PR?

DanielaBreitman · 2026-03-29T14:36:45Z

tests/test_lc_noise.py

I think we should include the comparison with 21cmsense as part of the testing.

Though this could be put into a new issue as part of improving testing in general as well.

Yeah, it takes a little bit of time to run -- I think it would be good as a test, but should be another PR.

DanielaBreitman · 2026-03-29T14:39:06Z

pyproject.toml

 dependencies = [
-    "21cmfast",
+    "21cmfast>=4.1.0",
    "21cmsense>=2.0.0",


Needs to be updated for new 21cmsense version

Yep, will need to merge that PR and make a release before merging this!

DanielaBreitman added 2 commits September 10, 2025 18:15

feat: Issue #48 feature 1

1fb3909

feat: Issue #48 feature 1

1ad06be

pre-commit-ci bot and others added 10 commits September 10, 2025 16:17

[pre-commit.ci] auto fixes from pre-commit.com hooks

872bb40

for more information, see https://pre-commit.ci

feat: Issue #48 feature 2

6317d88

feat: Issue #48 feature 2

7e847d7

feat: Issue #48 feature 2

446ad62

feat: Issue #48 feature 2

fb1c5c1

feat: Issue #48 feature 2

05055b9

feat: Issue #48 feature 2

71c791a

feat: Issue #48 feature 2

3dde869

feat: Issue #48 feature 2

81becd3

[pre-commit.ci] auto fixes from pre-commit.com hooks

ae21b85

for more information, see https://pre-commit.ci

DanielaBreitman requested a review from steven-murray September 11, 2025 16:12

DanielaBreitman and others added 3 commits September 11, 2025 18:44

feat: Issue #48 feature 2

65e9816

maint: fix tests

1131f98

[pre-commit.ci] auto fixes from pre-commit.com hooks

149c253

for more information, see https://pre-commit.ci

DanielaBreitman and others added 5 commits September 12, 2025 11:47

feat: Issue #48 finish fnc 1

6b4fec4

feat: Issue #48 finish fnc 2

76d1a4e

maint: fix tests

2766259

[pre-commit.ci] auto fixes from pre-commit.com hooks

028bf5d

for more information, see https://pre-commit.ci

maint: fix tests

6a9046e

DanielaBreitman requested a review from nikos-triantafyllou September 12, 2025 10:25

steven-murray reviewed Sep 12, 2025

View reviewed changes

nikos-triantafyllou reviewed Sep 12, 2025

View reviewed changes

src/tuesday/core/instrument_models/noise.py Outdated Show resolved Hide resolved

DanielaBreitman and others added 2 commits September 12, 2025 14:31

maint: fix Steven's comments

19e6565

[pre-commit.ci] auto fixes from pre-commit.com hooks

26e479f

for more information, see https://pre-commit.ci

steven-murray reviewed Sep 12, 2025

View reviewed changes

src/tuesday/core/instrument_models/noise.py Outdated Show resolved Hide resolved

steven-murray reviewed Sep 12, 2025

View reviewed changes

src/tuesday/core/instrument_models/noise.py Outdated Show resolved Hide resolved

pre-commit-ci bot and others added 5 commits September 12, 2025 17:38

[pre-commit.ci] auto fixes from pre-commit.com hooks

f737e0b

for more information, see https://pre-commit.ci

fix: wedge removal NOT done properly

9193db0

[pre-commit.ci] auto fixes from pre-commit.com hooks

9fcd546

for more information, see https://pre-commit.ci

refactor: change some function names and make lightcone obs more clear

12bb69d

maint: ignore ipynb checkpoints

fddae9a

steven-murray added 2 commits September 16, 2025 15:27

feat: add ability to apply spatial taper again

d845955

remove checkpoint files

3ccaaf9

nikos-triantafyllou reviewed Sep 18, 2025

View reviewed changes

docs/tutorials/lc_noise_compare_tools21cm.ipynb Outdated Show resolved Hide resolved

nikos-triantafyllou reviewed Sep 18, 2025

View reviewed changes

docs/tutorials/lc_noise_compare_tools21cm.ipynb Outdated Show resolved Hide resolved

steven-murray and others added 6 commits October 17, 2025 20:35

fix: scaling of uv grid and conjugate halving

46c146e

Fix 2 wedge removal bugs: Unnecessaru Fourier shifting and only remov…

df6ea78

…ing positive k_parallel

[pre-commit.ci] auto fixes from pre-commit.com hooks

ee0fcd7

for more information, see https://pre-commit.ci

feat: add ability to do inv variance weighting in map-making

57ba8ff

fix: correct uv gridding

b6ae16f

style: run ruff

b0cf2a9

steven-murray changed the title ~~feat: Issue #48 feature 1~~ feat: Mock observation of brightness temperature Mar 22, 2026

steven-murray and others added 5 commits March 22, 2026 09:57

Merge pull request #57 from nikos-triantafyllou/better_lc_noise

17249f0

Fix 2 wedge removal bugs: Unnecessary Fourier shifting and only removing positive k_parallel

fix: lightcone noise now matches 21cmSense

d1cdec6

style: apply pre-commit

f304f7f

docs: get all tutorials working

81877ab

docs: remove bad notebook

c544825

DanielaBreitman commented Mar 29, 2026

View reviewed changes

docs: formatting fixes

71fefa8

steven-murray mentioned this pull request Apr 2, 2026

Modify sig_uv calculation by removing scaling factor #58

Closed

		sigma is set to zero for uv cells with less than
		this number of baselines.

Conversation

DanielaBreitman commented Sep 10, 2025 • edited by steven-murray Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Sep 10, 2025

Uh oh!

codecov bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

steven-murray left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steven-murray commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

review-notebook-app bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielaBreitman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DanielaBreitman commented Sep 10, 2025 •

edited by steven-murray

Loading

codecov bot commented Sep 12, 2025 •

edited

Loading

review-notebook-app bot commented Mar 29, 2026 •

edited

Loading

review-notebook-app bot commented Mar 29, 2026 •

edited

Loading

review-notebook-app bot commented Mar 29, 2026 •

edited

Loading

review-notebook-app bot commented Mar 29, 2026 •

edited

Loading

review-notebook-app bot commented Mar 29, 2026 •

edited

Loading