fix(panel): hide empty monitor groups#130
Open
VictorBenitoGR wants to merge 1 commit into0ry0n:developfrom
Open
fix(panel): hide empty monitor groups#130VictorBenitoGR wants to merge 1 commit into0ry0n:developfrom
VictorBenitoGR wants to merge 1 commit into0ry0n:developfrom
Conversation
b3e1dae to
00114b8
Compare
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a panel spacing regression introduced in version 27 where disabled resource groups still reserved horizontal space in the GNOME top bar.
When only one item is visible, for example RAM usage, the indicator could still include spacing for hidden groups like CPU, swap, disk, network, and GPU. This made the panel item much wider than its visible content.
This change keeps the existing item order behavior, but hides whole panel groups when none of their metrics are visible.
Type of change
Validation
make validatepasses locally.Documentation and i18n
GNOME consistency checklist
Linked issues
Fixes #129
Target branch
develop