fix(panel): avoid iconless layout spacing#131
Open
VictorBenitoGR wants to merge 2 commits into0ry0n:developfrom
Open
fix(panel): avoid iconless layout spacing#131VictorBenitoGR wants to merge 2 commits into0ry0n:developfrom
VictorBenitoGR wants to merge 2 commits into0ry0n:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes iconless panel alignment so single-item displays stay visually centered.
When monitor icons were disabled, a simple display such as RAM percentage only could appear shifted to the left inside the GNOME top bar pill, leaving a small but noticeable extra space on the right.
This change keeps icons working normally when enabled, but removes icon actors from the panel layout when icons are disabled so they no longer affect alignment. It also keeps the spacing between multiple iconless monitor sections consistent with the previous visual spacing.
Note: this PR is stacked on top of #130 because it adjusts the panel group layout introduced there. It should be reviewed after #130.
Type of Change
Validation
make validatepasses locally.Documentation and i18n
GNOME Consistency Checklist
Linked Issues
Related to #129
Stacked on #130
Target Branch
develop