🎨 Palette: Accessible Modal Triggers#122
Conversation
- Added `role="button"` and `aria-haspopup="dialog"` to the anchor tags functioning as buttons. - Bound a `keydown` event listener for the Space key to prevent default scrolling and trigger the modal properly. - Added a `.Jules/palette.md` entry.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Converted generic
<a>tags withhref="#"that trigger modals into semantically correct buttons by addingrole="button"andaria-haspopup="dialog". Added a JavaScriptkeydownlistener to handle the 'Space' key properly for keyboard users.🎯 Why: Native anchor tags only trigger on the 'Enter' key and are announced as links by screen readers. When acting as buttons, they need to respond to both 'Enter' and 'Space' and be explicitly announced as buttons.
📸 Before/After: Visuals remain unchanged, but assistive technologies and keyboard navigation behavior are improved.
♿ Accessibility: Ensures that keyboard-only and screen reader users can interact with custom modal triggers consistently and predictably.
PR created automatically by Jules for task 7247227795159317562 started by @0m364