Use argument passed to OpenCmd without splitting
#3946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andriamanitra
approved these changes
Dec 17, 2025
Contributor
Andriamanitra
left a comment
Andriamanitra
left a comment
There was a problem hiding this comment.
I agree it looks like the code was left there by accident. I can't think of any use case where it would be useful. The old behavior has some weird consequences like open "a'b" not working because of an "unterminated single-quoted string", and open "a b" opening a b (with only one space!). With this change opening quoted files works more like one would expect.
JoeKar
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the first argument being split and joined, since the split is already by the command parser. Small details are provided in the commit message.
Fixes #1133