Skip to content

add a global option to always show the tab bar #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1ynxy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a global option to always show the tab bar #3882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions data/micro.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,11 @@
"type": "boolean",
"default": true
},
"tabalwaysshow": {
"description": "Wether to show the tab bar, even if only one tab exists\nhttps://github.com/zyedidia/micro/blob/master/runtime/help/options.md#options",
Copy link
Collaborator

@dmaluka dmaluka Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Wether/Whether/ ?

But more importantly, please document this in runtime/help/options.md.

As for this data/micro.json, I'm not even sure what it is for... Ok, just looked it up: it is some strange thing introduced in #2697 "to add intellisence for micro config", whatever that means. Basically we don't care about keeping it up to date.

"type": "boolean",
"default": false
},
"tabsize": {
"description": "A tab size\nhttps://github.com/zyedidia/micro/blob/master/runtime/help/options.md#options",
"type": "integer",
Expand Down
6 changes: 4 additions & 2 deletions internal/action/tab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ func (t *TabList) Resize() {
w, h := screen.Screen.Size()
iOffset := config.GetInfoBarOffset()
InfoBar.Resize(w, h-1)
if len(t.List) > 1 {
globalTabAlwaysShow := config.GetGlobalOption("tabalwaysshow").(bool)
Copy link
Collaborator

@dmaluka dmaluka Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: a separate variable doesn't seem useful here, we can just do if len(t.List) > 1 || config.GetGlobalOption("tabalwaysshow").(bool)?

Same for Display() below.

if len(t.List) > 1 || globalTabAlwaysShow {
for _, p := range t.List {
p.Y = 1
p.Node.Resize(w, h-1-iOffset)
Expand Down Expand Up @@ -144,7 +145,8 @@ func (t *TabList) HandleEvent(event tcell.Event) {
// Display updates the names and then displays the tab bar
func (t *TabList) Display() {
t.UpdateNames()
if len(t.List) > 1 {
globalTabAlwaysShow := config.GetGlobalOption("tabalwaysshow").(bool)
if len(t.List) > 1 || globalTabAlwaysShow {
t.TabWindow.Display()
}
}
Expand Down
1 change: 1 addition & 0 deletions internal/config/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ var DefaultGlobalOnlySettings = map[string]any{
"sucmd": "sudo",
"tabhighlight": false,
"tabreverse": true,
"tabalwaysshow": false,
Copy link
Collaborator

@dmaluka dmaluka Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep alphabetical order.

"xterm": false,
}

Expand Down
1 change: 1 addition & 0 deletions runtime/help/options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ so that you can see what the formatting should look like.
"tabhighlight": true,
"tabmovement": false,
"tabreverse": false,
"tabalwaysshow": false,
Copy link
Collaborator

@dmaluka dmaluka Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep alphabetical order.

"tabsize": 4,
"tabstospaces": false,
"useprimary": true,
Expand Down