fix: changed color of ZSH_HIGHLIGHT_COLOR[comment] #970
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, if we type comments (interactive comments (`#`) or "elided parameters in command position" (`$`)), then its fg is black which is not visible for the normal terminal users, so it doesn't makes any sense, so I changed it a greyish version to 245 so that it will be clearly visible
| : ${ZSH_HIGHLIGHT_STYLES[assign]:=none} | ||
| : ${ZSH_HIGHLIGHT_STYLES[redirection]:=fg=yellow} | ||
| : ${ZSH_HIGHLIGHT_STYLES[comment]:=fg=black,bold} | ||
| : ${ZSH_HIGHLIGHT_STYLES[comment]:=fg=245,bold} |
Member
There was a problem hiding this comment.
This assumes the terminal supports 256 colours. Is this assumption valid in all supported use-cases?
(It also assumes zsh supports that syntax, but I don't have time right now to look up when the fg=N syntax was added to zsh. Probably long enough ago.)
Member
|
To the other maintainers: I'm not sure whether I should be pressing "Approve workflows to run" right now or not. If workflows should be approved to run, could someone greenlight them, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, if we type comments (interactive comments (
#) or "elided parameters in command position" ($)), then its fg is black which is not visible for the normal terminal users, so it doesn't makes any sense, so I changed it a greyish version to 245 so that it will be clearly visible, fixed issue #969