Document login="interactive" and "keyring" connect() kwargs#250
Open
parejkoj wants to merge 2 commits intozooniverse:masterfrom
Open
Document login="interactive" and "keyring" connect() kwargs#250parejkoj wants to merge 2 commits intozooniverse:masterfrom
parejkoj wants to merge 2 commits intozooniverse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the PR #140 that added the interactive login kwarg to
connect(), but without finding that PR, I wouldn't have known about it. I added a docstring for theloginkwarg toconnect()here, but I think it would be good to document the various login methods in the user's guide as well. As it is, the only approach to establishing the connection that I can find in the docs involves writing your username and password directly in the script, which is very bad for security. But I'm not sure where in theuser_guide.rstsuch a discussion should go, nor do i know of all the possibilities.