Split twitch connections & JOIN on read connection only#17
Merged
Conversation
zneix
force-pushed
the
zneix/feat/split-twitch-connections
branch
from
45dffc1 to
db55c30
Compare
this also refactors the mod/vip detection logic with this change, we will no longer receive mod/vip data from intially JOINing the channel
anonymous connections can join channels very fast so we don't have to worry about slow JOINs anymore
zneix
force-pushed
the
zneix/feat/split-twitch-connections
branch
from
db55c30 to
e5b8914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have two connections to twitch instead of just one authenticated:
USERSTATEmessages - which are responsible for detecting bot being privileged or not.This also simplifies the mod/vip detection logic with newly available message user fields from go-twitch-irc.
With this change, we will no longer receive mod/vip data from intially JOINing the channel.