Fix parsing of access_token key from response JSON for OAUTH2#216
Open
prajwaltr93 wants to merge 8 commits intozmanda:3_5from
Open
Fix parsing of access_token key from response JSON for OAUTH2#216prajwaltr93 wants to merge 8 commits intozmanda:3_5from
access_token key from response JSON for OAUTH2#216prajwaltr93 wants to merge 8 commits intozmanda:3_5from
Conversation
prajwaltr93
force-pushed
the
3_5.fix_access_token_oauth2
branch
from
f0bc5c9 to
3b45e9f
Compare
prajwaltr93
force-pushed
the
3_5.fix_access_token_oauth2
branch
2 times, most recently
from
6c998e9 to
2daf8bb
Compare
- was not setting expires_in properly, causing fetch of access_token for every other request TODO: make use of HTTP/1.1 configurable
…ken_oauth2 - fetching latest changes since
prajwaltr93
force-pushed
the
3_5.fix_access_token_oauth2
branch
from
0563c62 to
ca0e02a
Compare
prajwaltr93
changed the title
access_token key from response JSON for OAUTH2access_token key from response JSON for OAUTH2
- new property to be set `http_v1_1`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using
OAUTH2as STORAGE_API with use of credentials such asclient_id,client_secretetc,access_tokenis first fetched and further requests use fetched token to perform request until it expires.regex used to parse response and get
access_tokenhad an extra trailing space, which is not present in response causing amanda to not parse it hence sending emptyaccess_tokeni.eAuthorization : Bearer (null).this fixes parsing, further enables users using
OAUTH2as authentication mechanism.fixes #214.
Changes:
Fix regex's parsing response to get valid set of credentials
Testing Changes.
account of no or more trailing space in regex's
make setting HTTP requests to 1.1 if user wishes to, by allowing settings another configuration in .conf