π Fix ReDoS vulnerability in pipe_to_shell regex#88
π Fix ReDoS vulnerability in pipe_to_shell regex#88google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π― What: Fixed a ReDoS vulnerability in the
β οΈ Risk: A long sequence of space characters combined with the overlapping
pipe_to_shellregex insidehooks/security_guard.py.\s+and.*capture groups could trigger exponential backtracking ($O(N^2)$), causing the regex engine to hang and denying service to the hook process.π‘οΈ Solution: Changed the regex from
\s+.*\|to\s[^|]*\|. This exactly matches at least one whitespace character (\s) while letting the negated character class[^|]*deterministically consume any remaining characters (including spaces) up to the pipe character|, thereby eliminating overlapping backtracking paths.PR created automatically by Jules for task 17491394274003151515 started by @zknpr