π Fix Symlink Attack vulnerability in _owner_only_opener#78
π Fix Symlink Attack vulnerability in _owner_only_opener#78google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π― What: Fixed a vulnerability in
_owner_only_openerinsidehooks/utils.pywhere theos.opencall could follow symbolic links when creating/opening sensitive files.~/.claude/for state/log files), the hook script would follow the symlink and enforce0o600permissions on the target, potentially altering or overwriting critical system files (e.g.,/etc/shadow) or other users' files, leading to privilege escalation or denial of service.π‘οΈ Solution: Added
flags |= getattr(os, "O_NOFOLLOW", 0)to theos.opencall within_owner_only_opener. This ensuresos.openfails with anOSErrorif the targeted path is a symlink. We gracefully fallback to0ifO_NOFOLLOWis not present (e.g. on older Windows versions). A new test was appended totests/test_utils.pyto assert this symlink rejection.PR created automatically by Jules for task 12170438649206231848 started by @zknpr