Open
Conversation
95DDB
requested changes
Jun 6, 2025
Collaborator
There was a problem hiding this comment.
All good overall, but I think that we could simplify a lot the code, considering that this pallet is not supposed to go in the runtime, except when running benchmarks (which are useful only for us, so perhaps not even worth to generate weight files). So we can try to:
- Gate the pallet inclusion in the runtime behind the feature "runtime-benchmarks". Take a look at
pallet_xcm_benchmarksto see an example on how to do it - We don't need the weight files in the runtime and in the pallet directories
- Perhaps we don't even need the mock file (useful only to run the benchmark test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.