Conversation
drgora
requested changes
Jan 16, 2026
Contributor
drgora
left a comment
drgora
left a comment
There was a problem hiding this comment.
Thanks for the change, which looks good to me. But on this repo we use the mainnet tag, and not zkverify, for the mainnet tags.
| fn_die "ERROR: Runtime in the tag (${tag_runtime}) does not match the expected runtime (${runtime}). Exiting ..." | ||
| fi | ||
|
|
||
| if [[ "${runtime}" = "zkverify" && -z "${version_ext}" ]]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [[ "${runtime}" = "zkverify" && -z "${version_ext}" ]]; then | |
| if [[ "${runtime}" = "mainnet" && -z "${version_ext}" ]]; then |
Contributor
Author
There was a problem hiding this comment.
Nice catch.... I've just copied and pasted it without brain 😄
| fi | ||
|
|
||
| if [[ "${runtime}" = "zkverify" && -z "${version_ext}" ]]; then | ||
| log_info "INFO: checking that zkverify and volta production release tags point to the same commit..." |
Contributor
There was a problem hiding this comment.
Suggested change
| log_info "INFO: checking that zkverify and volta production release tags point to the same commit..." | |
| log_info "INFO: checking that mainnet and volta production release tags point to the same commit..." |
| log_info "INFO: checking that zkverify and volta production release tags point to the same commit..." | ||
| volta_tag="rt-volta-${version}" | ||
| if [ "$(git_tag_commit "${github_tag}")" != "$(git_tag_commit "${volta_tag}")" ]; then | ||
| fn_die "ERROR: commit pointed to by zkverify tag (${github_tag}) does not match commit of volta tag (${volta_tag}). Exiting..." |
Contributor
There was a problem hiding this comment.
Suggested change
| fn_die "ERROR: commit pointed to by zkverify tag (${github_tag}) does not match commit of volta tag (${volta_tag}). Exiting..." | |
| fn_die "ERROR: commit pointed to by mainnet tag (${github_tag}) does not match commit of volta tag (${volta_tag}). Exiting..." |
…ase x.y.z tag is the same as mainnet.
la10736
force-pushed
the
md/ci-release-mainet-only-if-a-testnet-exists
branch
from
20ae3e0 to
a86e97f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.