Remove colorisation of repeaters with same prefix as red

[ericszimmermann]

This PR removes the feature to mark Repeaters with matching Prefixes as Red.

As also in Issue #352 explained, this is of no usage anymore:
This is due to the fact, that with the Discovery list (unlimited appstorage) you can get so many repeaters,
that you have multiple matches for every Repeater prefix, resulting just in marking every Repeater red without additional information gain.
For 1500 Repeaters and a one byte Prefix you get about 5 matches for every prefix.

Additionally the calculation is done in a repeater ^ 2 search method, and this not only once on map load, but on every map interaction (move/zoom).
(In my previous PR #298 I implemented a repeater ^ 1 approach to keep the functionality, but as written above I would now advertise to remove this.)

PS: I hope it is right to base it on dev-branch?

[446564]

looks ok, testing now

[446564]

no issues here

[446564]

Looks like we aren't going to be getting rid of this, but perhaps changing the way we do it.

from @zjs81:

I disagree. Realistically we should just do something like this

Prefixes = a1,a2,a1
If (getprefix).count() > 1{
Show red();
}

Then on click we get the repeaters lazily
That way if that entry is in the list more than once we mark it red we can cache that
So this pr could just fix it
This is still a useful signal because duplicate prefixes can impact dm messages
So we can just do this more efficiently instead of removing it
We could even build a frozen collection if dart supports that

[ericszimmermann]

Where is this quote from, because I seem to lack some of the context. He has a path from something? Or a selection of prefixes to mark red?

My point is, that if you have enough contacts, every possible prefix will have at least two matches, therefore just making the whole map red. With this implementation you can not even pair them up. If you have 4 repeaters, two with b7 and two with a3, all four will just show red. You can not distinguish wish is the alternative to the other, you would have to filter for the prefix, to get this information (another function, much more usefull for this).

Can there be given a usecase of when and how this function can be used?

Sincerely Eric

PS: I have of now 6 Repeaters on the Companion, which I interact with, the rest of the 350 fields are auto filled with contacts. And about 1097 Repeaters in the discovery list with further 233 old (autodeleted) contacts. This amount to about 4 Repeaters to every possible prefix.