Conversation
446564
force-pushed
the
rpt-guest
branch
2 times, most recently
from
09e8205 to
b599045
Compare
Collaborator
Author
|
ok pushed again with changed title and excluded battery chemistry info |
just-stuff-tm
suggested changes
Apr 10, 2026
Contributor
just-stuff-tm
left a comment
just-stuff-tm
left a comment
There was a problem hiding this comment.
All looks good except there should be guest helpers and titles on the login screen and the repeater screen...
Collaborator
Author
|
for the login it could just change to something like 'Enter the repeater password for guest or admin access' as we don't know if they are an admin until after login. I'll reword a few more things on the hub screen, looks like some of those tiles should change too. like stats is not also neighbors etc. maybe that should be another PR though. |
Collaborator
Author
|
ok ready for final review |
Contributor
|
Ok I'll build and approve |
just-stuff-tm
approved these changes
Apr 10, 2026
Contributor
just-stuff-tm
left a comment
just-stuff-tm
left a comment
There was a problem hiding this comment.
Good to merge into dev
zjs81
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds checks for the admin bit in the login response and a new pattern to exclude admin feature widgets etc
closes #8