Conversation
446564
added
Android
Collaborator
Author
|
oh, we have tests now? and they test behavior not code lol |
Contributor
Somebody added these a couple of weeks ago 😆 |
stphnrdmr
suggested changes
Apr 9, 2026
Contributor
stphnrdmr
left a comment
stphnrdmr
left a comment
There was a problem hiding this comment.
Looks good overall, just some small remarks. 👍
Collaborator
Author
|
still need to address tests |
446564
force-pushed
the
fix-bg-fg
branch
2 times, most recently
from
145ca83 to
57df3e9
Compare
446564
changed the title
stphnrdmr
reviewed
Apr 11, 2026
wraps MaterialApp in WithForegroundService to keep alive when swiped away persists last connected device and clears on manual disconnect to allow reconnect after kill added lifecycle tracking to iOS and keep android notification alive with heartbeat add notification navigation change screen tests to be less brittle address PR commnets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wraps MaterialApp in WithForegroundService to keep alive when swiped away
persists last connected device and clears on manual disconnect to allow
reconnect after kill
added lifecycle tracking to iOS and keep android notification alive with
heartbeat
add notification navigation
closes #58 until we decide to change the whole architecture.