Room integration and locale change #3

LoredanaZdranc · 2021-03-17T12:15:13Z

This branch contains:

Room integration with @insert, @query, and @delete examples
Locale changer demo
General error handling
General loading handler
Network handler to check internet connection
MotionLayout example

…radle(project level)

…) and finish its setup. Created classes for favorite users screen (fragment, module, view model, layout)

# Conflicts: # app/src/main/java/com/base_android_template/App.kt

…issue where FavoriteGithubUsersViewModel cannot be injected

…tabase in order to avoid null fields and created a method to map the GithubUserResponse to GithubUserEntity. Implemented insertGithubUsers(), getGithubUsers() and deleteGithubUsers() methods into GithubUsersListDao. Implemented the "Either", "NetworkHandler" and "ExceptionHandler" classes. Added an interface and its implementation for remote Github users list call. Implemented the DatabaseModule to inject room database related classes. Changed the implementation of GithubUsersListUseCase to fetch the list from server and to save it locally in database if the server returns success. Changed the logic in GithubUsersListViewModel to fetch firstly the local users list and if list is empty to call the server endpoint. Updated the adapter, view holder and diffUtil callback clasess to use GithubUserEntity instead of GIthubUserResponse

…ponseCall and NetworkResponseAdapterFactory classes.

…language selection in settings screen.

…nguage in Hawk when changing it. Removed language menu in MainActivity's toolbar. Implemented a BindingAdapters method responsible to set from layout the checked changed listener on RadioGroup

…e message. Animate using MotionLayout the title and the message when scrolling the users list.

…from the ViewModel

… exceptions inside GithubUsersViewModel

NegreaVlad · 2021-03-21T09:49:32Z

I changed the into branch to develop to avoid changes that were already reviewed

NegreaVlad

I reviewed some code, but not all of it. This is a partial review

NegreaVlad · 2021-03-21T10:03:00Z

app/src/main/AndroidManifest.xml

    <application
-        android:allowBackup="true"
        android:name=".App"
+        android:allowBackup="false"


Why do we want this?

NegreaVlad · 2021-03-21T10:21:02Z

app/src/main/java/com/base_android_template/di/CoreModules.kt

+
+    factory<UILoading> { UILoadingImplementation() }
+
+    single { ExceptionHandler() }


If this class doesn't implement an interface, there is no benefit of injecting it

NegreaVlad · 2021-03-21T10:24:56Z

app/src/main/java/com/base_android_template/remote/GithubUsersListRemoteImpl.kt

+    }
+
+    private suspend fun makeRequest(block: suspend () -> Response<List<GithubUserResponse>>): Either<Exception, List<GithubUserResponse>> {
+        if (!networkHandler.hasNetworkConnection()) {


I don't think it makes sense to check if there is an active network connection here, before making the call.
If we want to know if the error occurred because of no network, we can check that when getting 404 response

NegreaVlad · 2021-03-21T10:27:06Z

app/src/main/java/com/base_android_template/shared/network/Exception.kt

+    object NetworkException : Exception()
+    object ServerException : Exception()
+    object SaveGithubUsersException : Exception()
+    object EmptyLocalGithubUsersLisException : Exception()


"EmptyLocalGithubUsersLisException" -> EmptyLocalGithubUsersListException

NegreaVlad · 2021-03-21T14:44:28Z

app/src/main/java/com/base_android_template/shared/network/Exception.kt

@@ -0,0 +1,9 @@
+package com.base_android_template.shared.network
+
+sealed class Exception {


Having a general network exception is not good IMO because this class will get very large and you cannot understand anything.
Not all projects require the identification of network is down, or other general errors that can happen for all API calls.
I would like to have an error specific for each use case i.e a sealed class like this with errors specific only for github users and a GeneralError. We will not propagate more info downwards because I don't think it's needed for this project.
If certain error need to be treated in a certain way across all the app, then we can create a base class for errors, but it's not needed now.
The API can return a retrofit response which is analysed in the use case

NegreaVlad · 2021-03-21T14:50:08Z

app/src/main/java/com/base_android_template/shared/network/ExceptionHandler.kt

+
+class ExceptionHandler {
+
+    fun handleGeneralException(exception: Throwable): Either.Failure<Exception> = when (exception) {


The naming is wrong. "Handle" means something final. The exception is handled here and that's it. This is just a mapper

NegreaVlad · 2021-03-21T14:59:16Z

app/src/main/java/com/base_android_template/remote/GithubUsersListRemoteImpl.kt

+        return try {
+            val response = block.invoke()
+            handleResponse(response)
+        } catch (exception: Throwable) {


To avoid a too general catch, catch only java.io.IOException

NegreaVlad · 2021-03-21T15:10:34Z

app/src/main/java/com/base_android_template/feature/github_users/GithubUsersFragment.kt

+    override fun onActivityCreated(savedInstanceState: Bundle?) {
+        super.onActivityCreated(savedInstanceState)
+
+        viewModel.exception.observe(viewLifecycleOwner, {


This just calls view model logic. It doesn't do anything UI related. Why not put it in view model?

NegreaVlad · 2021-03-21T15:24:36Z

app/src/main/java/com/base_android_template/model/entity/GithubUserEntity.kt

+
+    companion object {
+
+        fun mapToGithubUserEntity(githubUserResponse: GithubUserResponse) =


We can implement an extension function instead of this. The call is cleaner IMO and we cannot use it without an instance of GithubUserResponse

NegreaVlad · 2021-03-21T15:32:01Z

app/src/main/java/com/base_android_template/feature/github_users/GithubUsersViewModel.kt

        }
    }
+
+    fun getRemoteGithubUsers() {


I think the logic of fetching from network or local database should be inside the use case, but I need to read more about this in order to provide good feedback.

…f there is an active network connection before making the call. If we want to know if the error occurred because of no network, we can check that when getting 404 response

…tException

… the Github users errors to handle in this way the errors by usecases

…odel. Moved the logic inside GithubUsersFragment -> onActivitCreated() to GithubUserViewModel. Implemented the SingleLiveEvent class to not clear every time the live data value

… GithubUserEntity

LoredanaZdranc added 20 commits February 24, 2021 13:52

Added Room library and extracted the libraries version inside build.g…

b608d04

…radle(project level)

Implemented a bottom navigation bar with two items (users & favorites…

9d38387

…) and finish its setup. Created classes for favorite users screen (fragment, module, view model, layout)

Added favorite icon for each Github User item

9058925

Created the Entity class for Room database -> Github Users

aaff585

Merge branch 'develop' into feature/local_persistance

55fb6ea

# Conflicts: # app/src/main/java/com/base_android_template/App.kt

Implemented GithubUsersDatabase and its corresponding DAO. Fixed the …

e5c653a

…issue where FavoriteGithubUsersViewModel cannot be injected

Added entities to GihubUsersDatabase

5818ff3

Removed unused ApiResponse, Error, NetworkResponseAdapter, NetworkRes…

0c22789

…ponseCall and NetworkResponseAdapterFactory classes.

Renamed favorite related classes to Settings. Implemented the UI for …

6a5ba95

…language selection in settings screen.

Implemented single choice selection for language settings. Persist la…

a5437d6

…nguage in Hawk when changing it. Removed language menu in MainActivity's toolbar. Implemented a BindingAdapters method responsible to set from layout the checked changed listener on RadioGroup

Set full screen app mode

1e04499

Changed the UI of Github users list screen by adding a title above th…

d361d84

…e message. Animate using MotionLayout the title and the message when scrolling the users list.

Implemented a general way to display a loading progress bar directly …

65625b6

…from the ViewModel

Implemented a general way to display messages in the app. Handled the…

4584c30

… exceptions inside GithubUsersViewModel

Increased the version code of some libraries

7d5ee9c

Removed unused BaseActivity class

a76fa2a

Commented the BaseFragment class

d54647f

Commented BaseViewModel class and methods

99f6bc6

Cleaned the code

74beeb6

LoredanaZdranc requested a review from NegreaVlad March 17, 2021 12:15

LoredanaZdranc self-assigned this Mar 17, 2021

NegreaVlad changed the base branch from main to develop March 21, 2021 09:48

NegreaVlad reviewed Mar 22, 2021

View reviewed changes

LoredanaZdranc added 5 commits March 23, 2021 11:41

Removed unused ressources

d3c0e2d

Removed allowBackup property in AndroidManifest

42825a5

Implemented ExceptionHandler as interface and created its implementation

bfd92a6

Removed NetworkHandler class because it doesn't make sense to check i…

7791128

…f there is an active network connection before making the call. If we want to know if the error occurred because of no network, we can check that when getting 404 response

Renamed EmptyLocalGithubUsersLisException to EmptyLocalGithubUsersLis…

b3c9610

…tException

LoredanaZdranc added 4 commits March 29, 2021 10:12

Removed Exception class and implemented a sealed class to handle only…

8a037fc

… the Github users errors to handle in this way the errors by usecases

Catch only java.io.IOException to avoid a too general catch.

0f21204

Implemented a general way to display the messages directly from ViewM…

02bcc9e

…odel. Moved the logic inside GithubUsersFragment -> onActivitCreated() to GithubUserViewModel. Implemented the SingleLiveEvent class to not clear every time the live data value

Implemented an extension function for GithubUserResponse to map it to…

9266a8b

… GithubUserEntity

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Room integration and locale change #3

Room integration and locale change #3

Uh oh!

LoredanaZdranc commented Mar 17, 2021

Uh oh!

NegreaVlad commented Mar 21, 2021

Uh oh!

NegreaVlad left a comment

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

NegreaVlad Mar 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		factory<UILoading> { UILoadingImplementation() }

		single { ExceptionHandler() }

		@@ -0,0 +1,9 @@
		package com.base_android_template.shared.network

		sealed class Exception {


		class ExceptionHandler {

		fun handleGeneralException(exception: Throwable): Either.Failure<Exception> = when (exception) {


		companion object {

		fun mapToGithubUserEntity(githubUserResponse: GithubUserResponse) =

Room integration and locale change #3

Are you sure you want to change the base?

Room integration and locale change #3

Uh oh!

Conversation

LoredanaZdranc commented Mar 17, 2021

Uh oh!

NegreaVlad commented Mar 21, 2021

Uh oh!

NegreaVlad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants