Emit fsm code in chunks as opposed single func.#2
Open
thanm wants to merge 1 commit intozhenjl:masterfrom
Open
Emit fsm code in chunks as opposed single func.#2thanm wants to merge 1 commit intozhenjl:masterfrom
thanm wants to merge 1 commit intozhenjl:masterfrom
Conversation
Changes genfsm.go to divide the state space into chunks of size 256, then call a helper for function for each chunk (as opposed to having a single giant function that does everything). This reduces the compile time for go1.7 down to something reasonable (15-30 seconds depending on machine speed). See related issues zhenjl#1 golang/go#16407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes genfsm.go to divide the state space into chunks
of size 256, then call a helper for function for each
chunk (as opposed to having a single giant function that
does everything). This reduces the compile time for go1.7
down to something reasonable (15-30 seconds depending on
machine speed). See related issues
#1
golang/go#16407