Add option to disable sending DNS requests via SOCKS proxy#318
Open
evgenyvolferts wants to merge 1 commit into
Open
Add option to disable sending DNS requests via SOCKS proxy#318evgenyvolferts wants to merge 1 commit into
evgenyvolferts wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Opening sites via SOCKS5 proxy with "auto switch" enabled fails when DNS-over-HTTPS is used in Firefox. This PR adds an option to disable sending the DNS requests via proxy. This can cause a DNS leak, but if a user has configured a trusted DoH server in browser - a leak should not be a problem.
Checkbox is enabled by default - so the default behavior is not changed.
This option was mentioned by @FelisCatus in sources earlier:
Compatibility
Is this PR compatible with old versions? Can users simply upgrade the extension?
Yes
Screenshots (if applicable)
After creating the PR:
bug or style fixes.
that project maintainers may reject new features, or request changes.