This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Moving NotFoundHandler to Handler namespace#192
Open
boesing wants to merge 4 commits into
Open
Conversation
As the `NotFoundHandler` technically is a `RequestHandler` and not a `Middleware`, we should pass it to the proper namespace.
While marking the `NotFoundHandler` in the `Middleware` namespace as deprecated, we are piping all the logic to the right `NotFoundHandler` by just invoking its `RequestHandlerInterface::handle` method
dennybrandes
suggested changes
Dec 4, 2019
geerteltink
approved these changes
Dec 9, 2019
Member
|
This repository has been closed and moved to laminas/laminas-stratigility; a new issue has been opened at laminas/laminas-stratigility#1. |
Member
|
This repository has been moved to laminas/laminas-stratigility. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe same procedure as in #191
As the
NotFoundHandleris technically aRequestHandler, I am moving it to theHandlernamespace instead while marking theNotFoundHandlerin theMiddlewarenamespace as deprecated.