feat: centralize operation inference, validate explicit vs inferred mismatch#6
Merged
Conversation
…ismatch Operation inference (CREATE/UPDATE/DELETE) now works consistently regardless of whether test fixtures are in separate files or consolidated in .request.yaml. Changes: - parseObjectYAML and parseOldObjectYAML no longer hardcode the operation (CREATE/DELETE). They build a partial AdmissionRequest with resource metadata only. - New inferOrValidateOperation() runs after all files are merged: - Empty operation: inferred from object/oldObject presence - Explicit operation matching inference: accepted - Explicit operation conflicting with inference: error - Explicit operation with no objects (e.g. CONNECT): accepted - InferOperation renamed to inferOperation (unexported, only used internally by inferOrValidateOperation). - Added ErrOperationMismatch sentinel error. - README Operations section updated to reflect that inference works the same way for both split files and .request.yaml. - go fix applied (evaluator, reporter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operation inference (CREATE/UPDATE/DELETE) now works consistently regardless of whether test fixtures are in separate files or consolidated in .request.yaml.
Changes: