feat: support all-in-one request.yaml, enforce gold files, improve README#5
Merged
Conversation
22ea8c9 to
973f4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support consolidating all test fixtures into a single
.request.yamlfile, add conflict detection when fields are defined in multiple files, enforce.gold.yamlfor mutating tests, and improve README for first-time users.Changes
All-in-one
.request.yamlobject,oldObject,params,namespaceObject,userInfo, and other fields can now all be defined in a single.request.yamlfile.object.yaml,.params.yaml, etc.).gold.yaml) lookup works from.request.yamlfiles for mutating testsConflict detection during merge
mergeTestRequestsnow returns an error if a field (object,oldObject,params,namespaceObject) is already set when merging from another fileconflictCheckstruct andcheckConflictsfunction — conflicts are detected generically at merge timeloadParamsFile,loadAuthorizerFile) fromparseObjectYAML/parseOldObjectYAML— the suite loop already handles these registered file types.namespaceObject.yamlsupportisTestFileandtestBaseNameparseNamespaceObjectYAMLparser withv1/NamespacevalidationEnforce
.gold.yamlfor mutating tests.gold.yamlis provided, the test fails with:"policy mutated the object but no .gold.yaml file was provided".expected.yamlto.gold.yamlinnamespace-selector-binding-mutatingtests (was silently ignored before)README rewrite
namespaceObject,authorizer,annotations,warnings)allow,deny,warn,audit)Test fixtures added
test-policies-pass: all-in-one.request.yamltests for validating and mutatingtest-policies-fail: object conflict detection, missing.gold.yaml