Implements gsys::MemBuffer

[VINZlehacker]

I decompiled the gsys::MemBuffer class.

---

This change is 

[Pistonight]

@Pistonight reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on VINZlehacker).

---

lib/gsys/src/gsys/gsysMemBuffer.cpp line 10 at r1 (raw file):

MemBuffer::MemBuffer() = default;
MemBuffer::~MemBuffer() = default;

Does it work when moving these to the header? (At least should be able to do the dtor virtual ~MemBuffer() = default;

---

lib/gsys/src/gsys/gsysMemBuffer.cpp line 29 at r1 (raw file):

void MemBuffer::free() {
    if (mBuffer)

Can you try without this if?

[VINZlehacker]

@VINZlehacker made 2 comments.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on Pistonight).

---

lib/gsys/src/gsys/gsysMemBuffer.cpp line 10 at r1 (raw file):

Previously, Pistonight (Michael Zhao) wrote…

Does it work when moving these to the header? (At least should be able to do the dtor virtual ~MemBuffer() = default;

No, if I do that, it will inline the constructor, and for the virtual destructor, it is sometimes called directly (without going through the vtable), and if I put it in the header, it will inline it in those cases.

---

lib/gsys/src/gsys/gsysMemBuffer.cpp line 29 at r1 (raw file):

Previously, Pistonight (Michael Zhao) wrote…

Can you try without this if?

Done.

[VINZlehacker]

lib/gsys/src/gsys/gsysMemBuffer.cpp line 10 at r1 (raw file):

Previously, VINZlehacker (auguste120) wrote…

No, if I do that, it will inline the constructor, and for the virtual destructor, it is sometimes called directly (without going through the vtable), and if I put it in the header, it will inline it in those cases.

Done.

[Pistonight]

LGTM now - one more thing: can you rebase and squash all the commits into one?

git remote add upstream git@github.com:zeldaret/botw
git fetch upstream
git rebase -i upstream/master

Change pick to fixup for all except the first commit in the rebase_todo file

git push -f

@Pistonight reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on VINZlehacker).

[VINZlehacker]

Done.

@VINZlehacker made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on VINZlehacker).

[VINZlehacker]

@VINZlehacker made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on VINZlehacker).

[Pistonight]

Thanks for the PR!