Merged
Conversation
- Add tick() before accessing qrVideoElement to avoid race condition - Clean up camera stream on error in startQrCamera - Reuse canvas/context across scanQrFrame calls to reduce GC churn - Add aria-labels to icon-only QR buttons - Fix QrCodeIcon import indentation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Closed
Deploying frontend with
|
| Latest commit: |
8d32af3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://971c423d.frontend-hvd.pages.dev |
| Branch Preview URL: | https://branta-qr-scan.frontend-hvd.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
frontend | 8d32af3 | Mar 26 2026, 11:30 PM |
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsqr)branta_id/branta_secretparamsReplaces #275 (rebased onto main, resolved conflicts, addressed Copilot review feedback).
Changes from #275
startQrCamerarace condition (await tick()before accessing conditionally-rendered video element)scanQrFramecalls to reduce GC churnaria-labelto icon-only QR scan and close buttonsQrCodeIconimport indentationTest plan
bitcoin:URI withbranta_id/branta_secret) and verify badge shows platform card🤖 Generated with Claude Code