Skip to content

Add formatPercentage method to Number class #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaibkhan wants to merge 5 commits into
base: 12.x
Choose a base branch
from
Open

Add formatPercentage method to Number class #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccf7ca4
Add formatPercentage method to Number class
zaibkhan Aug 29, 2025
fb61c17
Minor update to trigger AI review
zaibkhan Aug 29, 2025
39dd260
fixes added
zaibkhan Aug 31, 2025
61293d4
updated some spacing issue
zaibkhan Sep 2, 2025
04ba38f
updated some spacing issue
zaibkhan Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/Illuminate/Support/Number.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,4 +439,26 @@ protected static function ensureIntlExtensionIsInstalled()
throw new RuntimeException('The "intl" PHP extension is required to use the ['.$method.'] method.');
}
}

/**
* Format a number as a percentage with custom precision.
*
* @param float|int $number
* @param int $precision
* @param string|null $locale

@zaibkhan zaibkhan Sep 2, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ High: Delegate the formatPercentage method to the existing percentage method to ensure consistent behavior and reuse existing logic.

php
public static function formatPercentage($number, $precision = 2, $locale = null)
{
return static::percentage($number, $precision, null, $locale);
}

* @return string|false
*/
public static function formatPercentage($number, $precision = 2, $locale = null)
{

if (!is_numeric($number)) {
return false;
}

$formatter = new NumberFormatter($locale ?? app()->getLocale(), NumberFormatter::PERCENT);

$formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $precision);

return $formatter->format($number / 100);
}
}