Merged
Conversation
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Resolved duplicate class name errors (`root-case-clash.json`) by pre-calculating unique class names. - Fixed duplicate switch case labels in deserializers (`babel-config.json`) by grouping union variants by token. - Fixed syntax errors in `aws-cloudformation.json` by sanitizing variable names that collide with Java keywords (e.g., `default` -> `var1`) after CamelCase conversion. - Implemented `build_java_names` registry to ensure consistent naming across the generator. Co-authored-by: zahash <36153955+zahash@users.noreply.github.com>
- Implemented "try-parse" strategy using `JsonNode` and `mapper.treeToValue` for union variants that share the same `JsonToken` (e.g., multiple Object types). This resolves deserialization failures in `babel-config.json` where structurally different objects were being deserialized into the wrong class. - Retained fixes for class name deduplication (`root-case-clash.json`) and keyword sanitization (`aws-cloudformation.json`). - Updated `codegen-java` to import `JsonNode` and `ObjectMapper` when necessary. Co-authored-by: zahash <36153955+zahash@users.noreply.github.com>
Added ~72 new files to `test-data/` covering: - Development Tools (VSCode, ESLint, Prettier, etc.) - Package Managers (Composer, Cargo, Pub, etc.) - Cloud Infrastructure (Kubernetes, Terraform, AWS, Azure, GCP) - CI/CD Workflows (GitHub Actions, GitLab CI, CircleCI) - API Standards & Web (OpenAPI, AsyncAPI, RSS, Sitemap) - SaaS API Responses (Stripe, Slack, Discord, GitHub, etc.) - Data Science (Jupyter Notebooks, Vega-Lite) - Application Configs (Docker, Prometheus, Ansible) Includes JSON, YAML, TOML, XML, and IPYNB formats. Note: Some of these files may currently fail existing tests, exposing potential bugs or limitations in the code generators (e.g., `babel-config.json` ambiguous unions, `root-case-clash.json` naming collisions). Co-authored-by: zahash <36153955+zahash@users.noreply.github.com>
- Moved 147 test data files from `test-data/` root into nested subdirectories based on project/technology (e.g., `github/`, `aws/`, `vscode/`, `npm/`). - Updated `codegen-rust` and `codegen-java` test configurations to use recursive globbing (`../test-data/**/*.json`) to locate fixtures in the new structure. - Removed generic categories like `config-files` or `api-responses` in favor of specific tools/services (e.g., `stripe/`, `prometheus/`). - Moved core/generic tests to `core-types/` and `generic/`. Co-authored-by: zahash <36153955+zahash@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded the
test-datadirectory with high-quality, realistic files found in the wild. This includes configurations for popular tools, cloud infrastructure specs, and API responses. The addition supports future plans to handle multiple file formats beyond JSON.PR created automatically by Jules for task 5903447326596666114 started by @zahash