Skip to content

Update structure, implement vue starter kit conventions#3

Merged
zacksmash merged 6 commits into
mainfrom
directory
Aug 27, 2025
Merged

Update structure, implement vue starter kit conventions#3
zacksmash merged 6 commits into
mainfrom
directory

Conversation

@zacksmash
Copy link
Copy Markdown
Owner

This pull request refactors the codebase to standardize naming conventions, update configuration paths, and remove obsolete controller action files. The main focus is on improving consistency in directory and file naming (switching from PascalCase to camelCase), updating configuration and tooling to match these changes, and cleaning up unused code related to Fortify controller actions.

Naming and directory convention standardization:

  • Updated all Inertia Fortify view registrations in FortifyServiceProvider.php to use auth/ComponentName (camelCase) instead of Auth/ComponentName (PascalCase) for consistency.
  • Changed the page_paths entries in config/inertia.php from js/Pages to js/pages to align with the new naming convention. [1] [2]

Configuration and tooling updates:

  • Updated the ESLint config to ignore resources/js/wayfinder instead of resources/js/Http, reflecting the new directory structure.
  • Modified the composer.json wayfinder script to use the new path resources/js/wayfinder and added the --with-form option.

Code cleanup:

  • Removed all Fortify controller action files from resources/js/Http/actions/Laravel/Fortify/Http/Controllers/, which previously exported route definitions for authentication and profile actions. These are no longer needed after the refactor. [1] [2] [3] [4] [5] [6] [7]

Minor UI improvement:

  • Added styling for <mark> elements within header divs in resources/css/app.css to improve visual emphasis.

@zacksmash zacksmash requested a review from Copilot August 27, 2025 01:11
@zacksmash zacksmash self-assigned this Aug 27, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the codebase to implement Vue starter kit conventions by standardizing naming conventions from PascalCase to camelCase for directories and files, updating configuration paths accordingly, and cleaning up obsolete controller action files.

  • Updated directory naming from Pages/ to pages/ and Layouts/ to layouts/ throughout the codebase
  • Migrated from old @/Http/ based wayfinder actions to new @/wayfinder/ structure with form support
  • Removed all legacy Fortify controller action files and related routing infrastructure

Reviewed Changes

Copilot reviewed 45 out of 51 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vite.config.js Updated wayfinder path and enabled form variants
resources/views/app.blade.php Changed Vite path from Pages to pages
resources/js/ssr.ts Updated imports and page resolution paths to use camelCase
resources/js/pages/settings/*.vue Updated imports to use new wayfinder structure and improved form handling
resources/js/pages/auth/*.vue Migrated to new wayfinder imports and added proper layout definitions
resources/js/layouts/AuthLayout.vue Created simplified auth layout
resources/js/app.ts Updated page resolution and layout logic
resources/js/Http/ Removed legacy wayfinder and controller action files
resources/css/app.css Added styling for mark elements in headers
eslint.config.js Updated ignore path from Http to wayfinder
config/inertia.php Changed page paths from Pages to pages
composer.json Updated wayfinder script with new path and form option
app/Providers/FortifyServiceProvider.php Updated view paths from Auth/ to auth/
Comments suppressed due to low confidence (1)

resources/js/pages/auth/Login.vue:1

  • The reset-on-error prop was removed but this line appears to be incomplete. The line should either be removed entirely or properly closed if it was meant to be kept.
<script setup lang="ts">

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread resources/js/pages/settings/TwoFactorAuth.vue
Comment thread resources/js/pages/auth/VerifyEmail.vue
Comment thread resources/js/pages/auth/TwoFactorChallenge.vue
@zacksmash zacksmash merged commit f7dcb67 into main Aug 27, 2025
2 checks passed
@zacksmash zacksmash deleted the directory branch August 27, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants